-
Notifications
You must be signed in to change notification settings - Fork 248
s/kubernextes/kubernetes/g #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@DandyDeveloper @TheAlgo do we still want to follow the rules of every simple change need a version bump? |
Honestly, I don't think its my call anymore @peterzhuamazon I've said several times I don't believe spell checks / README updates need to worry about it chart version increments. It will fail in CI though but we can use our judgement on approval for merging. But, I am certain people disagree with me. |
I remember quoting this in some PR , that we should not bump versions for README and spell checks and ignore CI failures or relax them. Link : #152 (comment) |
Will wait a bit for this PR as I want to merge this right before another successful version bump so the pipeline will not show failure for a while. |
@daxxog Could you please sign off your commits because DCO checks are failing. Thanks Ref : https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
Yes, I did this commit quick TTW and it is signed with github's GPG key. I do have git configured properly with GPG on my workstation and can amend my commit to use that GPG key if it helps with your CI checks. |
We are talking about using |
Just a minor spelling thing. Signed-off-by: Volm, David <[email protected]>
@peterzhuamazon Just pulled down branch and re-signed with my key on my workstation -- pushed changed back up to origin. Used the command you posted, thanks for the tip! |
Thanks. DCO passed. Will leave this here a bit and merge it once another PR with version change ready, so your PR wont block a release. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Just a minor spelling thing.