Skip to content

s/kubernextes/kubernetes/g #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Conversation

daxxog
Copy link
Contributor

@daxxog daxxog commented Dec 31, 2021

Just a minor spelling thing.

@peterzhuamazon
Copy link
Member

@DandyDeveloper @TheAlgo do we still want to follow the rules of every simple change need a version bump?

@DandyDeveloper
Copy link
Collaborator

Honestly, I don't think its my call anymore @peterzhuamazon I've said several times I don't believe spell checks / README updates need to worry about it chart version increments. It will fail in CI though but we can use our judgement on approval for merging.

But, I am certain people disagree with me.

@TheAlgo
Copy link
Member

TheAlgo commented Jan 4, 2022

Honestly, I don't think its my call anymore @peterzhuamazon I've said several times I don't believe spell checks / README updates need to worry about it chart version increments. It will fail in CI though but we can use our judgement on approval for merging.

But, I am certain people disagree with me.

I remember quoting this in some PR , that we should not bump versions for README and spell checks and ignore CI failures or relax them.

Link : #152 (comment)

@peterzhuamazon
Copy link
Member

Will wait a bit for this PR as I want to merge this right before another successful version bump so the pipeline will not show failure for a while.

@TheAlgo
Copy link
Member

TheAlgo commented Jan 5, 2022

@daxxog Could you please sign off your commits because DCO checks are failing. Thanks

Ref : https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@daxxog
Copy link
Contributor Author

daxxog commented Jan 6, 2022

@daxxog Could you please sign off your commits because DCO checks are failing. Thanks

Ref : https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Screen Shot 2022-01-05 at 10 32 51 PM

Yes, I did this commit quick TTW and it is signed with github's GPG key.

I do have git configured properly with GPG on my workstation and can amend my commit to use that GPG key if it helps with your CI checks.

@peterzhuamazon
Copy link
Member

@daxxog Could you please sign off your commits because DCO checks are failing. Thanks
Ref : https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Screen Shot 2022-01-05 at 10 32 51 PM

Yes, I did this commit quick TTW and it is signed with github's GPG key.

I do have git configured properly with GPG on my workstation and can amend my commit to use that GPG key if it helps with your CI checks.

We are talking about using -s for signing DCO, not about -S signing GPG those are two things.
Could you git commit --amend --no-edit -s -S then push again?
Thanks.

Just a minor spelling thing.

Signed-off-by: Volm, David <[email protected]>
@daxxog
Copy link
Contributor Author

daxxog commented Jan 6, 2022

@peterzhuamazon Just pulled down branch and re-signed with my key on my workstation -- pushed changed back up to origin. Used the command you posted, thanks for the tip!

@peterzhuamazon
Copy link
Member

@peterzhuamazon Just pulled down branch and re-signed with my key on my workstation -- pushed changed back up to origin. Used the command you posted, thanks for the tip!

Thanks. DCO passed.
Ignore other failures you did not change code so lint is complaining version changes.

Will leave this here a bit and merge it once another PR with version change ready, so your PR wont block a release.

Thanks.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@peterzhuamazon peterzhuamazon merged commit 223a5d5 into opensearch-project:main Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants