Introduce new PPL commands, configuration and behavior changes #9790
Conversation
Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
requested review from
kolchfa-aws,
Naarcha-AWS,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Signed-off-by: Lantao Jin <[email protected]>
|
|
||
| ### Syntax | ||
|
|
||
| ```sql |
There was a problem hiding this comment.
Why you specify the language as sql?
There was a problem hiding this comment.
SQL and PPL share some common keywords which have as much syntax highlighting as possible. Any other suggestion?
There was a problem hiding this comment.
it is markdown hint, right?
There was a problem hiding this comment.
we could remove it. in rendered md file, not much syntax highlight for PPL.
There was a problem hiding this comment.
if remove it, we have to remove all 56 ```sql in this file, and more in other files.
There was a problem hiding this comment.
I think we can keep these for now.
Signed-off-by: Lantao Jin <[email protected]>
kolchfa-aws
added
v3.0.0
release-notes
|
|
||
| ### Syntax | ||
|
|
||
| ```sql |
There was a problem hiding this comment.
it is markdown hint, right?
|
|
||
| ### Syntax | ||
|
|
||
| ```sql |
There was a problem hiding this comment.
we could remove it. in rendered md file, not much syntax highlight for PPL.
_search-plugins/sql/ppl/subsearch.md
Outdated
| source = [ source = table1 | join left = l right = r [ source = table2 | where d > 10 | head 5 ] | stats count(a) by b ] as outer | head 1 | ||
| ``` | ||
|
|
||
| # Examples |
There was a problem hiding this comment.
Why we add TPC-H use case? Can you consider use cases that are familiar to OpenSearch users?
Signed-off-by: Lantao Jin <[email protected]>
|
@penghuo: Are there any additional technical changes that need to be made to this PR before we can move forward? |
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
|
@LantaoJin: I added my edits. Can you take a look at my changes and make sure I didn't miss anything? |
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
added
4 - Doc review
Description
SQL Plugin: Introduce new PPL commands, configuration and behavior changes
Issues Resolved
Closes #9765
Version
3.0.0
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.