-
Notifications
You must be signed in to change notification settings - Fork 575
Add MCP Connectors documentation #9757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MCP Connectors documentation #9757
Conversation
Signed-off-by: rithin-pullela-aws <[email protected]>
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Signed-off-by: rithin-pullela-aws <[email protected]>
### MCP Server | ||
A running MCP server (Any MCP-compliant implementation) accessible from your OpenSearch cluster. | ||
|
||
## Using MCP Tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add some brief introduction on what this use case is about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have mentioned this in the overview part
@rithin-pullela-aws Please let me know when you address tech review comments and we can start a doc review. We need a doc and editorial review before we can merge, and we have to release the docs 5/6. |
Signed-off-by: rithin-pullela-aws <[email protected]>
@kolchfa-aws, I have addressed the comments, can you please look into this, thank you!! |
Signed-off-by: Fanit Kolchina <[email protected]>
@rithin-pullela-aws I made my edits and pushed into your PR. I think this topic is best placed in the Agents and tools section. I also changed the name to be more precise. Please review my changes and verify that everything is correct. Thanks! |
Signed-off-by: kolchfa-aws <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
"mcp_connector_id": "<MCP_CONNECTOR_ID_FROM_STEP_1`>", | ||
"tool_filters": [ | ||
"^get_forecast", | ||
"search_indices" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add this ?
Suggest explain what tools are in the MCP server and what tools will be used with this filter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed this comment in a new commit, please take a look
Co-authored-by: Yaliang Wu <[email protected]> Signed-off-by: Rithin Pullela <[email protected]>
…out tool_filters regex matching condition Signed-off-by: rithin-pullela-aws <[email protected]>
@kolchfa-aws, I pushed another commit, please take a look |
Co-authored-by: Yaliang Wu <[email protected]> Signed-off-by: Rithin Pullela <[email protected]>
@@ -176,9 +176,9 @@ POST /_plugins/_ml/agents/_register | |||
"mcp_connectors": [ | |||
{ | |||
"mcp_connector_id": "<MCP_CONNECTOR_ID_FROM_STEP_1>", | |||
/* MCP server has get_alerts and get_forecasts tools, but only get_alerts will be included due to regex pattern */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rithin-pullela-aws We have a copy button on the requests, so they must be executable as is. Please move this to the intro sentence on line 155 and delete from here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure will update
@@ -74,7 +74,7 @@ The following table describes the connector parameters. For more information abo | |||
|
|||
| Parameter | Data type | Required | Description | | |||
|:----------|:---------|:------------| | |||
| `protocol` | String | Yes | Specify `mcp_sse` to use the SSE protocol (currently the only supported protocol type). | | |||
| `protocol` | String | Yes | Specify `mcp_sse` to use the SSE protocol (currently the only supported protocol type for MCP). | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove "currently". This is implied.
Signed-off-by: rithin-pullela-aws <[email protected]>
@kolchfa-aws @ylwu-amzn, I addressed the comments, can you help review the chanegs |
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Rithin Pullela <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Rithin Pullela <[email protected]>
Committed @kolchfa-aws's suggestions. |
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Rithin Pullela <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
* Add MCP Connectors documentation Signed-off-by: rithin-pullela-aws <[email protected]> * Change nav structure Signed-off-by: rithin-pullela-aws <[email protected]> * address comments Signed-off-by: rithin-pullela-aws <[email protected]> * Doc review Signed-off-by: Fanit Kolchina <[email protected]> * Fix links Signed-off-by: kolchfa-aws <[email protected]> * Apply suggestions from code review Signed-off-by: kolchfa-aws <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Update _ml-commons-plugin/agents-tools/mcp/mcp-connector.md Co-authored-by: Yaliang Wu <[email protected]> Signed-off-by: Rithin Pullela <[email protected]> * Add comment demonstrating tool filter working and add more details about tool_filters regex matching condition Signed-off-by: rithin-pullela-aws <[email protected]> * Update _ml-commons-plugin/agents-tools/mcp/mcp-connector.md Co-authored-by: Yaliang Wu <[email protected]> Signed-off-by: Rithin Pullela <[email protected]> * Address comments Signed-off-by: rithin-pullela-aws <[email protected]> * Update _ml-commons-plugin/agents-tools/mcp/mcp-connector.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Rithin Pullela <[email protected]> * Update _ml-commons-plugin/agents-tools/mcp/mcp-connector.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Rithin Pullela <[email protected]> * Update _ml-commons-plugin/agents-tools/mcp/mcp-connector.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Rithin Pullela <[email protected]> * Apply suggestions from code review Signed-off-by: kolchfa-aws <[email protected]> * Update _ml-commons-plugin/agents-tools/mcp/mcp-connector.md Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: rithin-pullela-aws <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Signed-off-by: Rithin Pullela <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Co-authored-by: Yaliang Wu <[email protected]>
Description
Adds documentation for the new feature which allows Agents to be provided with MCP Tools. Creating a new folder for MCP since many other features related to MCP will be added soon.
Issues Resolved
Closes #9758
Version
3.0
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.