Skip to content

Add MCP Connectors documentation #9757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 6, 2025

Conversation

rithin-pullela-aws
Copy link
Contributor

@rithin-pullela-aws rithin-pullela-aws commented Apr 28, 2025

Description

Adds documentation for the new feature which allows Agents to be provided with MCP Tools. Creating a new folder for MCP since many other features related to MCP will be added soon.

Issues Resolved

Closes #9758

Version

3.0

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: rithin-pullela-aws <[email protected]>
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

Signed-off-by: rithin-pullela-aws <[email protected]>
### MCP Server
A running MCP server (Any MCP-compliant implementation) accessible from your OpenSearch cluster.

## Using MCP Tools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some brief introduction on what this use case is about?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have mentioned this in the overview part

@kolchfa-aws kolchfa-aws added v3.0.0 3 - Tech review PR: Tech review in progress release-notes PR: Include this PR in the automated release notes labels Apr 29, 2025
@kolchfa-aws
Copy link
Collaborator

@rithin-pullela-aws Please let me know when you address tech review comments and we can start a doc review. We need a doc and editorial review before we can merge, and we have to release the docs 5/6.

Signed-off-by: rithin-pullela-aws <[email protected]>
@rithin-pullela-aws
Copy link
Contributor Author

@kolchfa-aws, I have addressed the comments, can you please look into this, thank you!!

Signed-off-by: Fanit Kolchina <[email protected]>
@kolchfa-aws
Copy link
Collaborator

@rithin-pullela-aws I made my edits and pushed into your PR. I think this topic is best placed in the Agents and tools section. I also changed the name to be more precise. Please review my changes and verify that everything is correct. Thanks!

Signed-off-by: kolchfa-aws <[email protected]>
@kolchfa-aws kolchfa-aws added 6 - Done but waiting to merge PR: The work is done and ready to merge and removed 5 - Editorial review PR: Editorial review in progress labels May 5, 2025
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"mcp_connector_id": "<MCP_CONNECTOR_ID_FROM_STEP_1`>",
"tool_filters": [
"^get_forecast",
"search_indices"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add this ?

Suggest explain what tools are in the MCP server and what tools will be used with this filter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed this comment in a new commit, please take a look

rithin-pullela-aws and others added 2 commits May 5, 2025 10:37
…out tool_filters regex matching condition

Signed-off-by: rithin-pullela-aws <[email protected]>
@rithin-pullela-aws
Copy link
Contributor Author

@kolchfa-aws, I pushed another commit, please take a look

@@ -176,9 +176,9 @@ POST /_plugins/_ml/agents/_register
"mcp_connectors": [
{
"mcp_connector_id": "<MCP_CONNECTOR_ID_FROM_STEP_1>",
/* MCP server has get_alerts and get_forecasts tools, but only get_alerts will be included due to regex pattern */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rithin-pullela-aws We have a copy button on the requests, so they must be executable as is. Please move this to the intro sentence on line 155 and delete from here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure will update

@@ -74,7 +74,7 @@ The following table describes the connector parameters. For more information abo

| Parameter | Data type | Required | Description |
|:----------|:---------|:------------|
| `protocol` | String | Yes | Specify `mcp_sse` to use the SSE protocol (currently the only supported protocol type). |
| `protocol` | String | Yes | Specify `mcp_sse` to use the SSE protocol (currently the only supported protocol type for MCP). |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove "currently". This is implied.

Signed-off-by: rithin-pullela-aws <[email protected]>
@rithin-pullela-aws
Copy link
Contributor Author

@kolchfa-aws @ylwu-amzn, I addressed the comments, can you help review the chanegs

rithin-pullela-aws and others added 2 commits May 5, 2025 12:24
@rithin-pullela-aws
Copy link
Contributor Author

Committed @kolchfa-aws's suggestions.

@kolchfa-aws kolchfa-aws merged commit 7638ee7 into opensearch-project:main May 6, 2025
5 checks passed
KishoreKicha14 pushed a commit to KishoreKicha14/documentation-website that referenced this pull request Jun 13, 2025
* Add MCP Connectors documentation

Signed-off-by: rithin-pullela-aws <[email protected]>

* Change nav structure

Signed-off-by: rithin-pullela-aws <[email protected]>

* address comments

Signed-off-by: rithin-pullela-aws <[email protected]>

* Doc review

Signed-off-by: Fanit Kolchina <[email protected]>

* Fix links

Signed-off-by: kolchfa-aws <[email protected]>

* Apply suggestions from code review

Signed-off-by: kolchfa-aws <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>

* Update _ml-commons-plugin/agents-tools/mcp/mcp-connector.md

Co-authored-by: Yaliang Wu <[email protected]>
Signed-off-by: Rithin Pullela <[email protected]>

* Add comment demonstrating tool filter working and add more details about tool_filters regex matching condition

Signed-off-by: rithin-pullela-aws <[email protected]>

* Update _ml-commons-plugin/agents-tools/mcp/mcp-connector.md

Co-authored-by: Yaliang Wu <[email protected]>
Signed-off-by: Rithin Pullela <[email protected]>

* Address comments

Signed-off-by: rithin-pullela-aws <[email protected]>

* Update _ml-commons-plugin/agents-tools/mcp/mcp-connector.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Rithin Pullela <[email protected]>

* Update _ml-commons-plugin/agents-tools/mcp/mcp-connector.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Rithin Pullela <[email protected]>

* Update _ml-commons-plugin/agents-tools/mcp/mcp-connector.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Rithin Pullela <[email protected]>

* Apply suggestions from code review

Signed-off-by: kolchfa-aws <[email protected]>

* Update _ml-commons-plugin/agents-tools/mcp/mcp-connector.md

Signed-off-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: rithin-pullela-aws <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Signed-off-by: Rithin Pullela <[email protected]>
Co-authored-by: Fanit Kolchina <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Co-authored-by: Yaliang Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6 - Done but waiting to merge PR: The work is done and ready to merge experimental release-notes PR: Include this PR in the automated release notes v3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Add MCP Connector Documentation
6 participants