Skip to content

Fix Terms, Term, MatchAll, MatchNone public docs #9595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2025

Conversation

karenyrx
Copy link
Contributor

@karenyrx karenyrx commented Apr 10, 2025

Description

  1. Add name and boost field to all 4 queries
  2. Remove boost from the terms query terms lookup parameters.
  3. store field was added in https://github.com/opensearch-project/OpenSearch/pull/14774/files to terms query terms lookup parameters, which looks like was part of 2.17 https://github.com/opensearch-project/OpenSearch/blob/2.17.0/server/src/internalClusterTest/java/org/opensearch/search/query/SearchQueryIT.java

Issues Resolved

Part of #30

Version

  1. All
  2. All
  3. 2.17 and beyond

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @karenyrx! LGTM

@kolchfa-aws
Copy link
Collaborator

@karenyrx Do you want to add store and value_type as part of this PR?

@karenyrx
Copy link
Contributor Author

Added store, and noticed value_type was already here so removed from PR description. Thanks!

@kolchfa-aws
Copy link
Collaborator

@karenyrx Thanks! Just one suggestion.

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Karen X <[email protected]>
@karenyrx
Copy link
Contributor Author

Thanks @kolchfa-aws! Updated.

@kolchfa-aws kolchfa-aws merged commit 6e993b6 into opensearch-project:main Apr 15, 2025
5 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 15, 2025
* Fix Terms, Term, MatchAll, MatchNone public docs

Signed-off-by: Karen Xu <[email protected]>

* add store

Signed-off-by: Karen Xu <[email protected]>

* Update _query-dsl/term/terms.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Karen X <[email protected]>

---------

Signed-off-by: Karen Xu <[email protected]>
Signed-off-by: Karen X <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit 6e993b6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants