docs(go.md): fix an error in the sample code between aws-sdk-go-v2 and opensearch-go/v4 that caused code to not compile. #9584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bootjp
requested review from
kolchfa-aws,
Naarcha-AWS,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
…d opensearch-go/v4 that caused code to not compile. Signed-off-by: bootjp/Yoshiaki Ueda <[email protected]>
bootjp
force-pushed
the
feature/fix_golang_doc
branch
from
5784a88 to
c06bb0a
Compare
kolchfa-aws
approved these changes
Apr 9, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 9, 2025
…d opensearch-go/v4 that caused code to not compile. (#9584) Signed-off-by: bootjp/Yoshiaki Ueda <[email protected]> (cherry picked from commit 0b67148) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an error in the Go client documentation sample code that caused it to not compile. The main issues were:
aws-sdk-go-v4to correctaws-sdk-go-v2As-Is: https://go.dev/play/p/QibehB7KI4r
To-Be: https://go.dev/play/p/5xJPsX8LFt2
Issues Resolved
N/A
Version
ALL
Frontend features
N/A
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.