Skip to content

adding null_value mapping parameter docs #9568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 11, 2025
Merged

adding null_value mapping parameter docs #9568

merged 6 commits into from
Apr 11, 2025

Conversation

AntonEliatra
Copy link
Contributor

Description

adding null_value mapping parameter docs

Version

all

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2025

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@AntonEliatra
fixing vale errors
d21fb67 
Signed-off-by: Anton Rubin <[email protected]>
@AntonEliatra
Merge branch 'adding-null_value-mapping-parameter-docs' of github.com…
e4972ea 
…:AntonEliatra/documentation-website into adding-null_value-mapping-parameter-docs
@kolchfa-aws
Copy link
Collaborator

@mgodwan Could you please review this PR? Thanks!

@kolchfa-aws kolchfa-aws added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Apr 8, 2025
kolchfa-aws
kolchfa-aws approved these changes Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AntonEliatra! Several suggestions for you before we move to editorial review.

@AntonEliatra @kolchfa-aws
Apply suggestions from code review
8e46892 
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
@kolchfa-aws kolchfa-aws added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Apr 10, 2025
natebower
natebower reviewed Apr 10, 2025
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntonEliatra Please see my changes and tag me for approval when addressed. Thanks!

@AntonEliatra @natebower
Apply suggestions from code review
bd87885 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
@AntonEliatra
Copy link
Contributor Author

@natebower thats been addressed now

natebower
natebower approved these changes Apr 11, 2025
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AntonEliatra! LGTM

@natebower natebower removed the 5 - Editorial review PR: Editorial review in progress label Apr 11, 2025
@natebower natebower merged commit 79cfdbf into opensearch-project:main Apr 11, 2025
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 11, 2025
@github-actions @kolchfa-aws @natebower
adding null_value mapping parameter docs (#9568)
c8ed901 
* adding null_value mapping parameter docs

Signed-off-by: Anton Rubin <[email protected]>

* fixing vale errors

Signed-off-by: Anton Rubin <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

---------

Signed-off-by: Anton Rubin <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit 79cfdbf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 11, 2025
Merged
@AntonEliatra AntonEliatra deleted the adding-null_value-mapping-parameter-docs branch April 11, 2025 11:53
github-actions bot pushed a commit that referenced this pull request Apr 11, 2025
@opensearch-trigger-bot
adding null_value mapping parameter docs (#9568) (#9601)
e7fa4c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgodwan mgodwan mgodwan approved these changes

@natebower natebower natebower approved these changes

@kolchfa-aws kolchfa-aws kolchfa-aws approved these changes

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@epugh epugh Awaiting requested review from epugh epugh is a code owner

Assignees

@kolchfa-aws kolchfa-aws

Labels
backport 2.19 Content gap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AntonEliatra @kolchfa-aws @mgodwan @natebower