Skip to content

adding normalizer mapping parameter docs #9558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 15, 2025
Merged

adding normalizer mapping parameter docs #9558

merged 4 commits into from
Apr 15, 2025

Conversation

AntonEliatra
Copy link
Contributor

Description

adding normalizer mapping parameter docs

Version

all

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2025

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@AntonEliatra
Update normalizer.md
a8da75a 
Signed-off-by: AntonEliatra <[email protected]>
@kolchfa-aws
Copy link
Collaborator

@dhwanilpatel Could you please review this PR? Thanks!

kolchfa-aws
kolchfa-aws reviewed Apr 11, 2025
View reviewed changes
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AntonEliatra! Please see my suggestions and let me know if you have any questions.

@kolchfa-aws kolchfa-aws added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Apr 11, 2025
@AntonEliatra @kolchfa-aws
Apply suggestions from code review
bb4f970 
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
@kolchfa-aws kolchfa-aws added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Apr 11, 2025
natebower
natebower reviewed Apr 14, 2025
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntonEliatra Please see my changes and tag me for approval when addressed. Thanks!

@AntonEliatra @natebower
Apply suggestions from code review
97a732d 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
natebower
natebower approved these changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AntonEliatra! LGTM

@natebower natebower removed the 5 - Editorial review PR: Editorial review in progress label Apr 15, 2025
@natebower natebower merged commit 276ae03 into opensearch-project:main Apr 15, 2025
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 15, 2025
@github-actions @kolchfa-aws @natebower
adding normalizer mapping parameter docs (#9558)
6c2d162 
* adding normalizer mapping parameter docs

Signed-off-by: Anton Rubin <[email protected]>

* Update normalizer.md

Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

---------

Signed-off-by: Anton Rubin <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit 276ae03)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 15, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Apr 15, 2025
@opensearch-trigger-bot
adding normalizer mapping parameter docs (#9558) (#9618)
823b98a
@AntonEliatra AntonEliatra deleted the adding-normalizer-mapping-parameter-docs branch April 16, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolchfa-aws kolchfa-aws kolchfa-aws left review comments

@dhwanilpatel dhwanilpatel dhwanilpatel approved these changes

@natebower natebower natebower approved these changes

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@epugh epugh Awaiting requested review from epugh epugh is a code owner

Assignees

@kolchfa-aws kolchfa-aws

Labels
backport 2.19 Content gap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AntonEliatra @kolchfa-aws @dhwanilpatel @natebower