Update geobounds aggregation. #9426
Conversation
Signed-off-by: Dave Welsch <[email protected]>
dwelsch-esi
requested review from
kolchfa-aws,
Naarcha-AWS,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
|
@rishabhmaurya Could you review this PR please? Thanks! |
There was a problem hiding this comment.
Thank you, @dwelsch-esi! Please see my comments and let me know if you have any questions. Please separate each REST request into its own code block. Thanks!
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Dave Welsch <[email protected]>
kolchfa-aws
added
4 - Doc review
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Dave Welsch <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Dave Welsch <[email protected]>
Signed-off-by: Dave Welsch <[email protected]>
Signed-off-by: Dave Welsch <[email protected]>
|
@kolchfa-aws Updated per review comments. Didn't do this very efficiently -- sorry about the extra commits. |
There was a problem hiding this comment.
Thank you, @dwelsch-esi! Just one more suggestion ("geopoints" is not in code font because the actual field type contains an underscore).
kolchfa-aws
added
5 - Editorial review
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Dave Welsch <[email protected]>
|
The number of commits doesn't matter because they are squashed when merged :) |
There was a problem hiding this comment.
@dwelsch-esi Please see my comments and changes and tag me for approval when addressed. Thanks!
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Dave Welsch <[email protected]>
* Update geobounds aggregation. Signed-off-by: Dave Welsch <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Dave Welsch <[email protected]> * Apply suggestions from code review Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Dave Welsch <[email protected]> * Update _aggregations/metric/geobounds.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Dave Welsch <[email protected]> * Update _aggregations/metric/geobounds.md Signed-off-by: Dave Welsch <[email protected]> * Apply suggestions from code review Signed-off-by: Dave Welsch <[email protected]> * Update _aggregations/metric/geobounds.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Dave Welsch <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Dave Welsch <[email protected]> --------- Signed-off-by: Dave Welsch <[email protected]> Signed-off-by: Dave Welsch <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit ba08b52) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
More complete descriptions, parameters table,
wrap_longitudeexample.Issues Resolved
Version
Frontend features
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.