Skip to content

Migration o19s/evaluation_lab to main branch #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 152 commits into from

Conversation

fen-qin
Copy link

@fen-qin fen-qin commented Jun 2, 2025

Description

  • rebase opensearch-projects/main
  • rebase o19s/evaluation_lab
  • trying to fix the build failure and address comments in o19s/migration branch

changes to fix build and integ tests failures:

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

fen-qin and others added 29 commits June 2, 2025 15:22
…arch-project#490)

* Add code formatting

Signed-off-by: Fen Qin <[email protected]>

* Add switch to old and new search relevance workbench experience

Signed-off-by: Fen Qin <[email protected]>

* change name conventions for APIs

Signed-off-by: Fen Qin <[email protected]>

* add search-relevance backend router

Signed-off-by: Fen Qin <[email protected]>

---------

Signed-off-by: Fen Qin <[email protected]>
…ch-project#493)

* fix missing route service files

Signed-off-by: Fen Qin <[email protected]>

* add DEVELOPER_GUIDE.md for middleware layer router setup for APIs

Signed-off-by: Fen Qin <[email protected]>

---------

Signed-off-by: Fen Qin <[email protected]>
Signed-off-by: wrigleyDan <[email protected]>
Signed-off-by: Fen Qin <[email protected]>
Signed-off-by: wrigleyDan <[email protected]>
Signed-off-by: Fen Qin <[email protected]>
Signed-off-by: wrigleyDan <[email protected]>
Signed-off-by: Fen Qin <[email protected]>
Signed-off-by: Fen Qin <[email protected]>

# Conflicts:
#	common/index.ts
#	public/components/api/search_relevance_testing_page.tsx
#	public/components/app.tsx
#	public/services.ts
#	server/clusters/search_relevance_plugin.ts
#	server/routes/search_relevance_route_service.ts
Signed-off-by: Fen Qin <[email protected]>
Signed-off-by: Alexey Rodriguez Yakushev <[email protected]>
Signed-off-by: Fen Qin <[email protected]>
Signed-off-by: wrigleyDan <[email protected]>
Signed-off-by: Fen Qin <[email protected]>
…ave judgment button only for llm experiment

Signed-off-by: wrigleyDan <[email protected]>
Signed-off-by: Fen Qin <[email protected]>
…jects retrieved from corresponding APIs.

Signed-off-by: wrigleyDan <[email protected]>
Signed-off-by: Fen Qin <[email protected]>
…ison experiment form

Signed-off-by: wrigleyDan <[email protected]>
Signed-off-by: Fen Qin <[email protected]>
Signed-off-by: wrigleyDan <[email protected]>
Signed-off-by: Fen Qin <[email protected]>
… use OpenSearch Dashboards conventions for frontend->backend connection to reduce boilerplate.

Signed-off-by: Alexey Rodriguez Yakushev <[email protected]>
Signed-off-by: Fen Qin <[email protected]>
@fen-qin
Copy link
Author

fen-qin commented Jun 2, 2025

changes to fix build and integ tests failures:

run integ tests against local cluster:

yarn cypress:run-without-security --config "baseUrl=http://localhost:5603/uqn" --spec "cypress/integration/plugins/search-relevance-dashboards/*.js"

     Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  plugins/search-relevance-dashboards      00:43        1        1        -        -        - │
  │    /1_query_compare.spec.js                                                                    │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/search-relevance-dashboards        2ms        -        -        -        -        - │
  │    /2_search_card.spec.js                                                                      │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        00:43        1        1        -        -        -  


Copy link

codecov bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 22.07792% with 60 lines in your changes missing coverage. Please review.

Project coverage is 61.78%. Comparing base (a51015a) to head (6394f4f).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
public/types/index.ts 11.47% 54 Missing ⚠️
...search_components/search_configs/search_config.tsx 45.45% 6 Missing ⚠️

❌ Your project check has failed because the head coverage (61.78%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #524       +/-   ##
===========================================
- Coverage   84.29%   61.78%   -22.52%     
===========================================
  Files          32       30        -2     
  Lines         433      505       +72     
  Branches       85      108       +23     
===========================================
- Hits          365      312       -53     
- Misses         47      158      +111     
- Partials       21       35       +14     
Flag Coverage Δ
dashboards-search-relevance 61.78% <22.07%> (-22.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fen-qin fen-qin force-pushed the migration branch 3 times, most recently from a5d2854 to fb290f2 Compare June 3, 2025 00:40
@fen-qin fen-qin force-pushed the migration branch 4 times, most recently from 2e30542 to f13d426 Compare June 3, 2025 22:42
@fen-qin
Copy link
Author

fen-qin commented Jun 3, 2025

  • changed the feature_flag defaulted value = false, integ tests failed due to route to new page
1_query_compare.spec.js.mp4
  • the root cause is this new commit set the test enabled = true

@fen-qin
Copy link
Author

fen-qin commented Jun 4, 2025

Command

yarn cypress:run-without-security \
--config "baseUrl=http://localhost:5601" \
--spec "cypress/integration/plugins/search-relevance-dashboards/*.js"

Tests passed


       Spec                                              Tests  Passing  Failing  Pending  Skipped
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  plugins/search-relevance-dashboards      02:18        1        1        -        -        - │
  │    /1_query_compare.spec.js                                                                    │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/search-relevance-dashboards        5ms        -        -        -        -        - │
  │    /2_search_card.spec.js                                                                      │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        02:18        1        1        -        -        -

✨  Done in 216.36s.

Video Clip

1_query_compare.spec.js.mp4

The FTR E2E SW workbench test failed might due to a cy.wait(10000) not long enough to render the experiment/create page

@fen-qin
Copy link
Author

fen-qin commented Jun 6, 2025

Merged the up to date UI feature flag PR to the branch. All CI checks passed

@fen-qin
Copy link
Author

fen-qin commented Jun 6, 2025

This PR is for fixing build and integ tests issue. Close the PR since tasks were completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants