-
Notifications
You must be signed in to change notification settings - Fork 63
Adding Amazon Network Firewall Integration #2410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Aaron Alvarez <[email protected]>
Signed-off-by: Aaron Alvarez <[email protected]>
Signed-off-by: Aaron Alvarez <[email protected]>
Signed-off-by: Aaron Alvarez <[email protected]>
* support custom logs correlation Signed-off-by: Shenoy Pratik <[email protected]> * add support for custom field mappings in logs Signed-off-by: Shenoy Pratik <[email protected]> * update explorer fields Signed-off-by: Shenoy Pratik <[email protected]> * add support for custom timestamp field Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Aaron Alvarez <[email protected]>
…ade by Simeon Signed-off-by: Aaron Alvarez <[email protected]>
Signed-off-by: Aaron Alvarez <[email protected]>
Signed-off-by: Aaron Alvarez <[email protected]>
Signed-off-by: Aaron Alvarez <[email protected]>
Signed-off-by: Aaron Alvarez <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2410 +/- ##
==========================================
- Coverage 56.53% 56.01% -0.52%
==========================================
Files 393 398 +5
Lines 15574 16072 +498
Branches 4284 4501 +217
==========================================
+ Hits 8804 9002 +198
- Misses 6705 6998 +293
- Partials 65 72 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
we should remove all the store files like: |
Signed-off-by: Aaron Alvarez <[email protected]>
Signed-off-by: Aaron Alvarez <[email protected]>
Signed-off-by: Aaron Alvarez <[email protected]>
server/adaptors/integrations/__data__/repository/amazon_networkfirewall/static/dashboard.png
Outdated
Show resolved
Hide resolved
...workfirewall/info/docs.aws.amazon.comnetwork-firewalllatestwhat-is-aws-network-firewall.html
Outdated
Show resolved
Hide resolved
server/adaptors/integrations/__data__/repository/amazon_networkfirewall/info/README.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aalva500-prog , great job for implementing this Network Firewall Integration. I just left some comments for the first round of review.
...rs/integrations/__data__/repository/amazon_networkfirewall/amazon_networkfirewall-1.0.0.json
Outdated
Show resolved
Hide resolved
.../integrations/__data__/repository/amazon_networkfirewall/assets/example_queries-1.0.0.ndjson
Show resolved
Hide resolved
server/adaptors/integrations/__data__/repository/amazon_networkfirewall/info/README.md
Show resolved
Hide resolved
...ations/__data__/repository/amazon_networkfirewall/assets/amazon_networkfirewall-1.0.0.ndjson
Show resolved
Hide resolved
Signed-off-by: Aaron Alvarez <[email protected]>
Signed-off-by: Aaron Alvarez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transferring some of the offline conversation with @aalva500-prog here:
...ntegrations/__data__/repository/amazon_networkfirewall/assets/create_mv_aggregated-1.0.0.sql
Outdated
Show resolved
Hide resolved
...ntegrations/__data__/repository/amazon_networkfirewall/assets/create_mv_aggregated-1.0.0.sql
Outdated
Show resolved
Hide resolved
...ations/__data__/repository/amazon_networkfirewall/assets/amazon_networkfirewall-1.0.0.ndjson
Show resolved
Hide resolved
Signed-off-by: Aaron Alvarez <[email protected]>
…Integration in the README file Signed-off-by: Aaron Alvarez <[email protected]>
Transferring some of the conversation with @aalva500-prog here again:
|
Signed-off-by: Aaron Alvarez <[email protected]>
Description
This PR adds Amazon Network Firewall Service as a new Integration. AWS Network Firewall is a managed network security service that helps protect your AWS Virtual Private Cloud (VPC) resources from network threats.
Issues Resolved
Video walkthrough
NFW1.mov
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.