Skip to content

Adding Amazon Network Firewall Integration #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Apr 14, 2025

Conversation

aalva500-prog
Copy link
Contributor

@aalva500-prog aalva500-prog commented Apr 8, 2025

Description

This PR adds Amazon Network Firewall Service as a new Integration. AWS Network Firewall is a managed network security service that helps protect your AWS Virtual Private Cloud (VPC) resources from network threats.

Issues Resolved

  • An integration is a bundle of pre-canned assets which are brought together in a meaningful manner.
  • AWS Network Firewall integration includes dashboards, visualizations, queries, and an index mapping.

Video walkthrough

NFW1.mov

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

aaarone90 and others added 14 commits March 7, 2025 16:40
* support custom logs correlation

Signed-off-by: Shenoy Pratik <[email protected]>

* add support for custom field mappings in logs

Signed-off-by: Shenoy Pratik <[email protected]>

* update explorer fields

Signed-off-by: Shenoy Pratik <[email protected]>

* add support for custom timestamp field

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Aaron Alvarez <[email protected]>
@RyanL1997 RyanL1997 added the integrations Used to denote items related to the Integrations project label Apr 8, 2025
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.01%. Comparing base (5cfbba1) to head (b7ea7b7).
Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2410      +/-   ##
==========================================
- Coverage   56.53%   56.01%   -0.52%     
==========================================
  Files         393      398       +5     
  Lines       15574    16072     +498     
  Branches     4284     4501     +217     
==========================================
+ Hits         8804     9002     +198     
- Misses       6705     6998     +293     
- Partials       65       72       +7     
Flag Coverage Δ
dashboards-observability 56.01% <ø> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RyanL1997
Copy link
Collaborator

we should remove all the store files like: server/adaptors/integrations/__data__/repository/.DS_Store

Signed-off-by: Aaron Alvarez <[email protected]>
Signed-off-by: Aaron Alvarez <[email protected]>
@Swiddis Swiddis added the enhancement New feature or request label Apr 9, 2025
Copy link
Collaborator

@RyanL1997 RyanL1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aalva500-prog , great job for implementing this Network Firewall Integration. I just left some comments for the first round of review.

Signed-off-by: Aaron Alvarez <[email protected]>
Signed-off-by: Aaron Alvarez <[email protected]>
Copy link
Collaborator

@RyanL1997 RyanL1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transferring some of the offline conversation with @aalva500-prog here:

…Integration in the README file

Signed-off-by: Aaron Alvarez <[email protected]>
@RyanL1997
Copy link
Collaborator

Transferring some of the conversation with @aalva500-prog here again:

  • @aalva500-prog observed that in the aggregated version of dashboards had some full log table view panels, which we should remove from the aggregated version of dashboards, since the timesstamp was been trimmed into the 5mins chunk based on the TUMBLE() we had in our aggregated version of MV query
  • We have also made a comparison of the index size of both full index mv and aggregated mv, and we observed that the query aggregation doesn't shrink the MV size much. After checking the reference of raw log field cardinality, we observed that the aggregated MV is still using some high cardinality fields

@aalva500-prog aalva500-prog requested a review from RyanL1997 April 11, 2025 02:05
@RyanL1997 RyanL1997 merged commit 02e384b into opensearch-project:main Apr 14, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request integrations Used to denote items related to the Integrations project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants