Traces - Update custom source display, add toast. #2403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Tackett <[email protected]>
ps48
reviewed
Apr 4, 2025
| @@ -187,7 +187,7 @@ export const getTracesQuery = ( | |||
| }, | |||
| }, | |||
| }, | |||
| track_total_hits: false, | |||
| track_total_hits: true, | |||
There was a problem hiding this comment.
nit. This is true by default if we don't provide the field here.
ps48
approved these changes
Apr 4, 2025
ps48
reviewed
Apr 4, 2025
Comment on lines
58
to
60
| } catch { | ||
| // not JSON, skip | ||
| } |
There was a problem hiding this comment.
I think we don't a separate try catch here.
There was a problem hiding this comment.
Removed empty catch
joshuali925
approved these changes
Apr 4, 2025
| @@ -35,6 +36,50 @@ export async function handleDslRequest( | |||
| const query = { | |||
| dataSourceMDSId, | |||
| }; | |||
|
|
|||
| const handleError = (error: any) => { | |||
There was a problem hiding this comment.
this function might need unit tests to make it easier to understand the examples of error variable, and to ensure there's no regression
There was a problem hiding this comment.
Extraced handleError to a helper_functions file and included tested for it
public/components/trace_analytics/requests/tests/helper_funtions.test.tsx
PASS public/components/trace_analytics/requests/__tests__/helper_funtions.test.tsx (5.281 s)
handleError in handleDslRequest
✓ displays danger toast for too_many_buckets_exception (1 ms)
✓ logs error for non-bucket exceptions
✓ parses nested message JSON string (1 ms)
Signed-off-by: Adam Tackett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Toast message:
Updated warning in corner:
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.