Skip to content

Application Analytics - Flaky cypress fix #2402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 7, 2025

Conversation

TackAdam
Copy link
Collaborator

@TackAdam TackAdam commented Apr 3, 2025

Description

Application Analytics had three test that were attempting actions before loading was complete if the browser was slow. This was causing flakiness. Adding

cy.get('[data-test-subj="globalLoadingIndicator"]').should('not.exist');

Ensures the actions wait until the elements exist and make the test always pass.

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Adam Tackett <[email protected]>
@TackAdam TackAdam added the bug Something isn't working label Apr 3, 2025
@TackAdam TackAdam marked this pull request as ready for review April 7, 2025 17:29
@TackAdam TackAdam merged commit 54477cc into opensearch-project:main Apr 7, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants