Skip to content

fix prometheus response parsing issue #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

YANG-DB
Copy link
Member

@YANG-DB YANG-DB commented Apr 29, 2024

Description

fix parsing but [object Object] is not valid JSON in prometheus metrics

Issues Resolved

#1665

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@Swiddis Swiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding unit tests for this as well, a lot of how the original issue happened was from a lack of testing for this

@Swiddis Swiddis added bug Something isn't working backport 2.x labels Apr 29, 2024
@YANG-DB
Copy link
Member Author

YANG-DB commented Apr 29, 2024

Screen.Recording.2024-04-29.at.4.43.03.PM.mov

@YANG-DB YANG-DB merged commit 6a230ba into opensearch-project:main Apr 30, 2024
20 of 27 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1757-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6a230ba38a0e6882568d5c8f63b4b56ecb0a62f8
# Push it to GitHub
git push --set-upstream origin backport/backport-1757-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1757-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.14 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.14 2.14
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.14
# Create a new branch
git switch --create backport/backport-1757-to-2.14
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6a230ba38a0e6882568d5c8f63b4b56ecb0a62f8
# Push it to GitHub
git push --set-upstream origin backport/backport-1757-to-2.14
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.14

Then, create a pull request where the base branch is 2.14 and the compare/head branch is backport/backport-1757-to-2.14.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1757-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6a230ba38a0e6882568d5c8f63b4b56ecb0a62f8
# Push it to GitHub
git push --set-upstream origin backport/backport-1757-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1757-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.14 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.14 2.14
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.14
# Create a new branch
git switch --create backport/backport-1757-to-2.14
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6a230ba38a0e6882568d5c8f63b4b56ecb0a62f8
# Push it to GitHub
git push --set-upstream origin backport/backport-1757-to-2.14
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.14

Then, create a pull request where the base branch is 2.14 and the compare/head branch is backport/backport-1757-to-2.14.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1757-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6a230ba38a0e6882568d5c8f63b4b56ecb0a62f8
# Push it to GitHub
git push --set-upstream origin backport/backport-1757-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1757-to-2.x.

Swiddis pushed a commit to Swiddis/dashboards-observability that referenced this pull request Apr 30, 2024
Swiddis added a commit that referenced this pull request May 1, 2024
* Add 2.14 release notes

Signed-off-by: Simeon Widdis <[email protected]>

* fix issue #1665 (#1757)

Signed-off-by: YANGDB <[email protected]>

* Revert "Add 2.14 release notes"

This reverts commit 42ac9c4.

Signed-off-by: Simeon Widdis <[email protected]>

---------

Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: YANGDB <[email protected]>
Co-authored-by: YANGDB <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 1, 2024
* Add 2.14 release notes

Signed-off-by: Simeon Widdis <[email protected]>

* fix issue #1665 (#1757)

Signed-off-by: YANGDB <[email protected]>

* Revert "Add 2.14 release notes"

This reverts commit 42ac9c4.

Signed-off-by: Simeon Widdis <[email protected]>

---------

Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: YANGDB <[email protected]>
Co-authored-by: YANGDB <[email protected]>
(cherry picked from commit f9a6e49)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Swiddis added a commit that referenced this pull request May 1, 2024
* Add 2.14 release notes



* fix issue #1665 (#1757)



* Revert "Add 2.14 release notes"

This reverts commit 42ac9c4.



---------




(cherry picked from commit f9a6e49)

Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: YANGDB <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: YANGDB <[email protected]>
Co-authored-by: Simeon Widdis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants