Skip to content

removed update button from explorer #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

paulstn
Copy link
Collaborator

@paulstn paulstn commented Apr 29, 2024

Description

The update button was replaced by the run button in Explorer, but now both are being shown. Removing the update button since the search bar was most recently developed with the run button

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Paul Sebastian <[email protected]>
@paulstn paulstn force-pushed the remove-update-button branch from c29212a to eabbc79 Compare April 29, 2024 23:14
@Swiddis
Copy link
Collaborator

Swiddis commented Apr 30, 2024

Needs a snapshot update

@Swiddis Swiddis merged commit cb845f2 into opensearch-project:main Apr 30, 2024
16 of 21 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 30, 2024
* remove update button

Signed-off-by: Paul Sebastian <[email protected]>

* update snapshot

Signed-off-by: Paul Sebastian <[email protected]>

---------

Signed-off-by: Paul Sebastian <[email protected]>
(cherry picked from commit cb845f2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 30, 2024
* remove update button

Signed-off-by: Paul Sebastian <[email protected]>

* update snapshot

Signed-off-by: Paul Sebastian <[email protected]>

---------

Signed-off-by: Paul Sebastian <[email protected]>
(cherry picked from commit cb845f2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@paulstn paulstn deleted the remove-update-button branch April 30, 2024 22:57
paulstn pushed a commit that referenced this pull request May 3, 2024
* remove update button



* update snapshot



---------


(cherry picked from commit cb845f2)

Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…arch-project#1775)

* remove update button



* update snapshot



---------


(cherry picked from commit cb845f2)

Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants