[BUG-Fixed] #1466 - create observability dashboard after invalid name #1730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…after creating with Invalid name ### Fix for [BUG] Cannot create observability dashboard after creating with invalid name opensearch-project#1466 - opensearch-project#1466 ### Description Cannot create Observability Dashboards after creating with an Invalid Name ### Issues Resolved Dialog asking user to input Dashboard Name even if invalid Dashboard name is entered ### Check List - [x] New functionality includes testing. - [x] All tests pass, including unit test, integration test and doctest - [ ] New functionality has been documented. - [ ] New functionality has javadoc added - [ ] New functionality has user manual doc added - [x] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). Signed-off-by: Mahima Arora <[email protected]>
Mahima081
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
YANG-DB
approved these changes
Apr 26, 2024
Swiddis
approved these changes
Apr 29, 2024
|
Panels integ test "Displays error toast for invalid panel name" is failing, looks like the test needs to be updated for the new text. Happy to merge after it's updated. |
RyanL1997
approved these changes
May 7, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
…h Invalid name (#1730) ### Fix for [BUG] Cannot create observability dashboard after creating with invalid name #1466 - #1466 ### Description Cannot create Observability Dashboards after creating with an Invalid Name ### Issues Resolved Dialog asking user to input Dashboard Name even if invalid Dashboard name is entered ### Check List - [x] New functionality includes testing. - [x] All tests pass, including unit test, integration test and doctest - [ ] New functionality has been documented. - [ ] New functionality has javadoc added - [ ] New functionality has user manual doc added - [x] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). Signed-off-by: Mahima Arora <[email protected]> (cherry picked from commit b328720) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for [BUG] Cannot create observability dashboard after creating with invalid name #1466 - #1466
Description
Cannot create Observability Dashboards after creating with an Invalid Name
Issues Resolved
Dialog asking user to input Dashboard Name even if invalid Dashboard name is entered
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.