Skip to content

[Integrations] Add integration of S3 Access log #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

RyanL1997
Copy link
Collaborator

@RyanL1997 RyanL1997 commented Apr 11, 2024

Description

Add integration of S3 Access log

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@RyanL1997 RyanL1997 added integrations Used to denote items related to the Integrations project backport 2.x enhancement New feature or request labels Apr 11, 2024
@RyanL1997 RyanL1997 changed the title [Integration] Add integration of S3 Access log [Integrations] Add integration of S3 Access log Apr 11, 2024
Copy link
Member

@YANG-DB YANG-DB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change names according to naming convention shown here

  • Table name
  • MV names
  • Dashboard name
  • visualizations name
    -- TBD next version ...

@RyanL1997 RyanL1997 force-pushed the s3-access-integration branch from 3b6c376 to 0dfb2ff Compare April 15, 2024 22:28
@YANG-DB YANG-DB merged commit ee0d748 into opensearch-project:main Apr 15, 2024
14 of 19 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 15, 2024
* Add integration of S3 Access log

Signed-off-by: Ryan Liang <[email protected]>

* Correct the checkpoint placeholder

Signed-off-by: Ryan Liang <[email protected]>

* Correct the parsing of timestamp

Signed-off-by: Ryan Liang <[email protected]>

* Correct the auto refresh config boolean

Signed-off-by: Ryan Liang <[email protected]>

---------

Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit ee0d748)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
)

* Add integration of S3 Access log

Signed-off-by: Ryan Liang <[email protected]>

* Correct the checkpoint placeholder

Signed-off-by: Ryan Liang <[email protected]>

* Correct the parsing of timestamp

Signed-off-by: Ryan Liang <[email protected]>

* Correct the auto refresh config boolean

Signed-off-by: Ryan Liang <[email protected]>

---------

Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit ee0d748)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request integrations Used to denote items related to the Integrations project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants