Skip to content

fix small issues within explorer search bar and sample query #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

paulstn
Copy link
Collaborator

@paulstn paulstn commented Apr 11, 2024

Description

Fixes:

  • Typo with SHOW TABLES query -> SHOW TABLE
  • unexpected behavior where the autocomplete component's shift enter listener populates the ran query as something stale, for direct queries
  • non direct query updates everything needed now

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@paulstn paulstn added bug Something isn't working backport 2.x labels Apr 11, 2024
@paulstn paulstn merged commit 2126a15 into opensearch-project:main Apr 11, 2024
18 of 24 checks passed
@paulstn paulstn deleted the explorer-sample-query-search-bar-changes branch April 11, 2024 17:19
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 11, 2024
…1683)

Signed-off-by: Paul Sebastian <[email protected]>
(cherry picked from commit 2126a15)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
paulstn pushed a commit that referenced this pull request Apr 11, 2024
…1683) (#1686)

(cherry picked from commit 2126a15)

Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
RyanL1997 pushed a commit to RyanL1997/dashboards-observability that referenced this pull request Apr 18, 2024
…point (opensearch-project#1650) (opensearch-project#1683)

* Added client certificate options to support mutual TLS

---------

Signed-off-by: Calvin Harrison <[email protected]>
Signed-off-by: Simple-Analysis <[email protected]>
Co-authored-by: Peter Nied <[email protected]>
(cherry picked from commit ec661f8847e090c3293bb018c08b51625232cbf5)

Co-authored-by: Simple-Analysis <[email protected]>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…pensearch-project#1683) (opensearch-project#1686)

(cherry picked from commit 2126a15)

Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 89fef23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants