Skip to content

[Backport 2.x] prevent logged out datasources call (#1653) #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

paulstn
Copy link
Collaborator

@paulstn paulstn commented Apr 5, 2024

  • prevent logged out datasources call

Signed-off-by: Paul Sebastian [email protected]

  • check if security plugin is installed

Signed-off-by: Paul Sebastian [email protected]

  • clean up logic

Signed-off-by: Paul Sebastian [email protected]

  • include a catch clause to register datasources when account api has non 401 error

Signed-off-by: Paul Sebastian [email protected]

  • included comment

Signed-off-by: Paul Sebastian [email protected]


Signed-off-by: Paul Sebastian [email protected]
(cherry picked from commit c14c3f8)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* prevent logged out datasources call

Signed-off-by: Paul Sebastian <[email protected]>

* check if security plugin is installed

Signed-off-by: Paul Sebastian <[email protected]>

* clean up logic

Signed-off-by: Paul Sebastian <[email protected]>

* include a catch clause to register datasources when account api has non 401 error

Signed-off-by: Paul Sebastian <[email protected]>

* included comment

Signed-off-by: Paul Sebastian <[email protected]>

---------

Signed-off-by: Paul Sebastian <[email protected]>
(cherry picked from commit c14c3f8)
@ps48 ps48 changed the title prevent logged out datasources call (#1653) [Backport 2.x] prevent logged out datasources call (#1653) Apr 5, 2024
@paulstn paulstn added the bug Something isn't working label Apr 5, 2024
@paulstn paulstn marked this pull request as ready for review April 5, 2024 00:19
@paulstn paulstn merged commit cdfeefd into 2.x Apr 5, 2024
23 of 35 checks passed
@github-actions github-actions bot deleted the backport/backport-1653-to-2.x branch April 5, 2024 00:25
RyanL1997 pushed a commit to RyanL1997/dashboards-observability that referenced this pull request Apr 18, 2024
…roject#1672)

Signed-off-by: [email protected] <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>
(cherry picked from commit 8f1334edc5d6114e14a9220e377c5da887e3e8e1)

Co-authored-by: leanneeliatra <[email protected]>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…arch-project#1672)

* prevent logged out datasources call

Signed-off-by: Paul Sebastian <[email protected]>

* check if security plugin is installed

Signed-off-by: Paul Sebastian <[email protected]>

* clean up logic

Signed-off-by: Paul Sebastian <[email protected]>

* include a catch clause to register datasources when account api has non 401 error

Signed-off-by: Paul Sebastian <[email protected]>

* included comment

Signed-off-by: Paul Sebastian <[email protected]>

---------

Signed-off-by: Paul Sebastian <[email protected]>
(cherry picked from commit c14c3f8)
(cherry picked from commit cdfeefd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants