Skip to content

(query assist) remove caching agent id #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

joshuali925
Copy link
Member

Description

similar to opensearch-project/dashboards-assistant#165

Issues Resolved

opensearch-project/dashboards-assistant#154

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Li <[email protected]>
@joshuali925 joshuali925 changed the title remove caching agent id (query assist) remove caching agent id Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.96%. Comparing base (9a4e532) to head (bf6da7b).

❗ Current head bf6da7b differs from pull request most recent head 59ee9b5. Consider uploading reports for the commit 59ee9b5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1529      +/-   ##
==========================================
- Coverage   57.52%   56.96%   -0.57%     
==========================================
  Files         352      348       -4     
  Lines       12925    12696     -229     
  Branches     3336     3211     -125     
==========================================
- Hits         7435     7232     -203     
+ Misses       5434     5411      -23     
+ Partials       56       53       -3     
Flag Coverage Δ
dashboards-observability 56.96% <100.00%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulstn paulstn merged commit 01bec05 into opensearch-project:main Mar 15, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 22, 2024
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Co-authored-by: Paul Sebastian <[email protected]>
(cherry picked from commit 01bec05)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants