Skip to content

Misc improvements IV #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 9, 2025
Merged

Misc improvements IV #743

merged 6 commits into from
Jun 9, 2025

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Jun 5, 2025

Description

Continuation of #736.

  • hide scrollbar by default for left nav, to keep width consistent across monitor resolutions and sizes
  • multiple enhancements to the source data modal: increased vertical space for the json lines text editor, removed extra spacing below the cancel/confirm btns, and removed text wrapping, to more cleanly display the JSON line. Users can horizontally scroll to see the entire line, if it overflows. The vertical spacing was maximized such that on a laptop screen with browser at 100%, with 3 errors, there is no vertical overflow, to minimize any chance of the user not scrolling and missing the errors or what the expected format is
  • increase vertical space for test query panel in Inspect
  • remove overflow on delete modal from workflow list page

No relevant screenshots to add. Everything is the same, just minor tuning of the spacing and behavior to maximize workable space.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler ohltyler added the enhancement New feature or request label Jun 5, 2025
@ohltyler ohltyler added the v3.1.0 label Jun 5, 2025
@ohltyler ohltyler marked this pull request as draft June 5, 2025 22:09
@ohltyler ohltyler marked this pull request as ready for review June 9, 2025 16:35
@saimedhi
Copy link
Collaborator

saimedhi commented Jun 9, 2025

LGTM. Will merge once tests pass.

@saimedhi saimedhi merged commit fb1eef9 into opensearch-project:main Jun 9, 2025
7 of 9 checks passed
@ohltyler ohltyler deleted the nits-2 branch June 9, 2025 16:56
@saimedhi saimedhi mentioned this pull request Jun 10, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants