Skip to content

Resolve invalid map with raw json in BasicReplicationIT.kt #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented May 3, 2025

Description

Resolve invalid map with raw json in BasicReplicationIT.kt

Based on a80be44

  • Add missing type
  • Correct index name on the 4 dimension entry
  • Disable JSM settings

Related Issues

#1523

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mohit Kumar <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>

Co-authored-by: Mohit Kumar <[email protected]>
Co-authored-by: Peter Zhu <[email protected]>
Copy link
Member

@cwperks cwperks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock the release. Every other plugin I have checked sets test.security.manager to false for the integTestRemote task so this makes CCR in line with other plugins.

@github-project-automation github-project-automation bot moved this from Backlog to In review in OpenSearch Engineering Effectiveness May 3, 2025
@monusingh-1 monusingh-1 merged commit 8d7c76f into opensearch-project:3.0 May 3, 2025
17 of 18 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board May 3, 2025
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 3, 2025
@peterzhuamazon peterzhuamazon deleted the 3.0.0 branch May 3, 2025 05:45
monusingh-1 pushed a commit that referenced this pull request May 3, 2025
…1538)

Co-authored-by: Mohit Kumar <[email protected]>
(cherry picked from commit 8d7c76f)

Co-authored-by: Peter Zhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants