Backports #1850, #1854, #1856 to 2.19 #1858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* change doc level monitor fanout action to first calculate max seq_no and then fetch docs Signed-off-by: Surya Sashank Nistala <[email protected]> * add timeoutwrapped listener to timebox doc level monitor execution by adding timeouts before submitting fianout Signed-off-by: Surya Sashank Nistala <[email protected]> * change timeout test verification to verify execution result contains no findings due to timeout and correct no of findings after updating timeout setting back to normal Signed-off-by: Surya Sashank Nistala <[email protected]> * remove index patterns from tests Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]>
…ect#1856) Signed-off-by: Surya Sashank Nistala <[email protected]>
…ensearch-project#1854) Signed-off-by: Surya Sashank Nistala <[email protected]>
AWSHurneyt
reviewed
May 30, 2025
| Setting.Property.NodeScope, Setting.Property.Dynamic | ||
| ) | ||
|
|
||
| /** Setting to help timebox doc level monitor execution |
There was a problem hiding this comment.
Not a blocking comment; just adding this here for visibility.
My understanding is that if an execution times out before processing all of the docs, the leftover docs should be processed by the next execution. We should mention in troubleshooting documentation that if it seems like monitor executions are consistently timing out before processing all docs, the cluster may need to be scaled up/out.
AWSHurneyt
approved these changes
May 30, 2025
sbcd90
approved these changes
May 30, 2025
Signed-off-by: Surya Sashank Nistala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backports to 2.19
prevent dry run execution of doc level monitor with index pattern (https://github.com/opensearch-project/alerting/pull/1854[)](https://github.com/opensearch-project/alerting/commit/9bf6d544dd765cdf9bd16741528e7c03b258f3ad)
use transport service timeout instead of custom impl (https://github.com/opensearch-project/alerting/pull/1856[)](https://github.com/opensearch-project/alerting/commit/705997167f4c97cf03e5d9f0ad30bfddb1f1cb0d)
Timebox doc level monitor execution (https://github.com/opensearch-project/alerting/pull/1850[)](https://github.com/opensearch-project/alerting/commit/97c83ce8e16525eb34e5dc8250c5e873cf3df80f)