Fixing org.opensearch.monitor.os.OsProbeTests::testLogWarnCpuMessageOlyOnes when CGroups are not available

[reta]

Signed-off-by: Andriy Redko [email protected]

Description

The newly added org.opensearch.monitor.os.OsProbeTests::testLogWarnCpuMessageOlyOnes test case always assumes that CGroups are available but this may not be the case. The test fails otherwise:

org.opensearch.monitor.os.OsProbeTests > testLogWarnCpuMessageOnlyOnes FAILED                                                                                                                                                                                                                                                                                                               
    Wanted but not invoked:                                                                                                                                                                                                                                                                                                                                                                 
    logger.warn(<any string>);                                                                                                                                                                                                                                                                                                                                                              
    -> at org.opensearch.monitor.os.OsProbeTests.testLogWarnCpuMessageOnlyOnes(OsProbeTests.java:300)                                                                                                                                                                                                                                                                                       
    Actually, there were zero interactions with this mock.                                                                                                                                                                                                                                                                                                                                  
        at __randomizedtesting.SeedInfo.seed([98F51BCCE98CC711:506380649692FF1F]:0)                                                                                                                                                                                                                                                                                                         
        at app//org.opensearch.monitor.os.OsProbeTests.testLogWarnCpuMessageOnlyOnes(OsProbeTests.java:300) 

Issues Resolved

N/A

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[opensearch-ci-bot]

Can one of the admins verify this patch?

[willyborankin]

Ahhh true. Not all distros and OS wanna have cgorups. thnx

[opensearch-ci-bot]

✅   Gradle Check success 00193fc
Log 2376

Reports 2376

[dblock]

For my education, what platform were you able to reproduce this on?

[reta]

For my education, what platform were you able to reproduce this on?

Mine is Ubuntu 21.10, but Windows will fail as well