Skip to content

Add support for Warm Indices Write Block on Flood Watermark breach #18375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jun 18, 2025
Merged

Add support for Warm Indices Write Block on Flood Watermark breach #18375

merged 16 commits into from
Jun 18, 2025
+993 −193

Conversation

Gagan6164
Copy link
Contributor

@Gagan6164 Gagan6164 commented May 27, 2025 •
edited
Loading

Description

Add support for Warm Indices Write Block on Flood Watermark breach

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for d73241f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request May 26, 2025
Open
@Gagan6164 Gagan6164 force-pushed the AddWarmDiskMonitor branch 2 times, most recently from 7a5016d to d73241f Compare June 8, 2025 11:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 8, 2025

✅ Gradle check result for 3c9e688: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Jun 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 74.28571% with 36 lines in your changes missing coverage. Please review.

Project coverage is 72.72%. Comparing base (a7f28f6) to head (5668c5c).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ting/allocation/HotNodeDiskThresholdEvaluator.java 24.00% 16 Missing and 3 partials ⚠️
.../cluster/routing/allocation/NodeDiskEvaluator.java 68.96% 9 Missing ⚠️
...uster/routing/allocation/DiskThresholdMonitor.java 92.59% 0 Missing and 4 partials ⚠️
...ing/allocation/WarmNodeDiskThresholdEvaluator.java 85.71% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #18375      +/-   ##
============================================
- Coverage     72.75%   72.72%   -0.04%     
- Complexity    68087    68106      +19     
============================================
  Files          5537     5540       +3     
  Lines        313232   313321      +89     
  Branches      45458    45461       +3     
============================================
- Hits         227905   227865      -40     
- Misses        66758    66892     +134     
+ Partials      18569    18564       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

❕ Gradle check result for 341e34a: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@Gagan6164 Gagan6164 marked this pull request as ready for review June 10, 2025 04:06
@Gagan6164 Gagan6164 requested a review from a team as a code owner June 10, 2025 04:06
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for e7d8710: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Gagan6164 and others added 2 commits June 11, 2025 19:34
@Gagan6164
Merge branch 'main' into AddWarmDiskMonitor
ccab093 
Signed-off-by: Gagan6164 <[email protected]>
gradlew spotless fix
3570c0d 
Signed-off-by: Gagan Singh Saini <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 3570c0d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Resolve comments
e1a7fa6 
Signed-off-by: Gagan Singh Saini <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for e1a7fa6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Jun 11, 2025
Open
Open
Open
Gagan Singh Saini added 2 commits June 12, 2025 12:18
small change
4209aab 
Signed-off-by: Gagan Singh Saini <[email protected]>
Add Changelog
bdd3945 
Signed-off-by: Gagan Singh Saini <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for bdd3945: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Spotless fix
6e7922c 
Signed-off-by: Gagan Singh Saini <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 6e7922c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for f588845: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Jun 12, 2025
Open
Open
Resolving comments
326f1ea 
Signed-off-by: Gagan Singh Saini <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 326f1ea: SUCCESS

Gagan Singh Saini and others added 2 commits June 18, 2025 10:44
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for c8b17e2: SUCCESS

@Gagan6164
Update CHANGELOG.md
5668c5c 
Signed-off-by: Gagan6164 <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 5668c5c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jun 18, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 5668c5c: SUCCESS

@gbbafna gbbafna merged commit 9dc2a88 into opensearch-project:main Jun 18, 2025
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skumawat2025 skumawat2025 skumawat2025 left review comments

@gbbafna gbbafna gbbafna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gagan6164 @skumawat2025 @gbbafna