Skip to content

Add example plugins for mapping transformer and system ingest processor. #18300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

bzhangam
Copy link
Contributor

@bzhangam bzhangam commented May 14, 2025

Description

Add example plugins for mapping transformer and system ingest processor.

Since this change is for example plugins we don't add it to the change log.

Related Issues

Provide example plugins and integration tests for the mapping transformer and system ingest processor.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@bzhangam bzhangam requested a review from a team as a code owner May 14, 2025 21:39
@bzhangam bzhangam force-pushed the exampleplugins branch 3 times, most recently from 48380e9 to 60783f8 Compare May 14, 2025 21:48
Copy link
Contributor

❌ Gradle check result for 60783f8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@bzhangam bzhangam force-pushed the exampleplugins branch 2 times, most recently from 3f511ed to d6cd5d8 Compare May 14, 2025 22:25
Copy link
Contributor

❕ Gradle check result for d6cd5d8: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 80.64516% with 12 lines in your changes missing coverage. Please review.

Project coverage is 72.65%. Comparing base (d52cefa) to head (485e572).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...processor/ExampleSystemIngestProcessorFactory.java 77.41% 2 Missing and 5 partials ⚠️
.../mappingtransformer/ExampleMappingTransformer.java 80.00% 0 Missing and 3 partials ⚠️
...mingestprocessor/ExampleSystemIngestProcessor.java 83.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18300      +/-   ##
============================================
- Coverage     72.74%   72.65%   -0.09%     
+ Complexity    67767    67736      -31     
============================================
  Files          5497     5504       +7     
  Lines        311815   311926     +111     
  Branches      45261    45286      +25     
============================================
- Hits         226822   226631     -191     
- Misses        66504    66776     +272     
- Partials      18489    18519      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

❌ Gradle check result for 72d38bf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@bzhangam bzhangam closed this May 15, 2025
@bzhangam bzhangam reopened this May 15, 2025
Copy link
Contributor

❌ Gradle check result for 72d38bf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 44bc5de: SUCCESS

Copy link
Contributor

✅ Gradle check result for deb67c1: SUCCESS

Copy link
Member

@saratvemulapalli saratvemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this.
Dropped a minor comment, you could follow up with a different PR.
Also could you take care of the code coverage ? The patch threshold did not get through.

@bzhangam bzhangam reopened this Jun 2, 2025
Copy link
Contributor

github-actions bot commented Jun 2, 2025

❌ Gradle check result for 485e572: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 2, 2025

✅ Gradle check result for 485e572: SUCCESS

@saratvemulapalli saratvemulapalli merged commit d8e2680 into opensearch-project:main Jun 2, 2025
48 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants