-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add example plugins for mapping transformer and system ingest processor. #18300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example plugins for mapping transformer and system ingest processor. #18300
Conversation
48380e9
to
60783f8
Compare
❌ Gradle check result for 60783f8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
3f511ed
to
d6cd5d8
Compare
❕ Gradle check result for d6cd5d8: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18300 +/- ##
============================================
- Coverage 72.74% 72.65% -0.09%
+ Complexity 67767 67736 -31
============================================
Files 5497 5504 +7
Lines 311815 311926 +111
Branches 45261 45286 +25
============================================
- Hits 226822 226631 -191
- Misses 66504 66776 +272
- Partials 18489 18519 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
❌ Gradle check result for 72d38bf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 72d38bf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care of this.
Dropped a minor comment, you could follow up with a different PR.
Also could you take care of the code coverage ? The patch threshold did not get through.
...src/main/java/org/opensearch/example/systemingestprocessor/ExampleSystemIngestProcessor.java
Show resolved
Hide resolved
Signed-off-by: Bo Zhang <[email protected]>
❌ Gradle check result for 485e572: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
d8e2680
into
opensearch-project:main
Description
Add example plugins for mapping transformer and system ingest processor.
Since this change is for example plugins we don't add it to the change log.
Related Issues
Provide example plugins and integration tests for the mapping transformer and system ingest processor.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.