Gracefully tear down S3BlobContainerRetriesTests #18144
Merged
+4
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe the test tear down is racing with the thread leak detector because the `shutdown()` method does not actually wait for all the threads to stop. The fix here is to use `ThreadPool::terminate` which does the proper shutdown and ensures are threads are stopped before returning from the tearDown method. Signed-off-by: Andrew Ross <[email protected]>
andrross
requested review from
anasalkouz,
ashking94,
bugmakerrrrrr,
Bukhtawar,
CEHENKLE,
cwperks,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
github-actions
bot
added
>test-failure
|
Looks promising as a general fix for thread leak scenarios. |
|
❕ Gradle check result for b82351d: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18144 +/- ##
============================================
- Coverage 72.56% 72.52% -0.04%
- Complexity 67227 67232 +5
============================================
Files 5476 5476
Lines 310445 310445
Branches 45124 45124
============================================
- Hits 225261 225163 -98
- Misses 66786 66942 +156
+ Partials 18398 18340 -58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the test tear down is racing with the thread leak detector because the
shutdown()method does not actually wait for all the threads to stop. The fix here is to useThreadPool::terminatewhich does the proper shutdown and ensures are threads are stopped before returning from the tearDown method.Related Issues
Resolves #17551
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.