Skip to content

[Star tree] Removing star tree indexing and queries added till 2.19 out of expermental #18070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

bharath-techie
Copy link
Contributor

@bharath-techie bharath-techie commented Apr 24, 2025

Removing feature flag for star tree index and queries that are introduced by 2.19

Description

  1. Indexing has remained same since 2.18 for the most part. And in 2.19 , we have support for date histogram, metric aggregations and term / terms / range query support. So removing feature flag protection for these features.
  2. Still the newer queries and newer aggregations must be behind a feature flag - date range query, nested aggregations and boolean queries are yet to be merged. Have restricted terms aggs and range aggs in this PR. [ server/src/main/java/org/opensearch/search/startree/StarTreeQueryContext.java]
  3. In both search (server/src/main/java/org/opensearch/search/DefaultSearchContext.java) and indexing validations (server/src/main/java/org/opensearch/index/compositeindex/datacube/startree/StarTreeValidator.java) , we first check for explicit index setting and if present, we use the value otherwise we fallback to cluster setting.
  4. By default both the cluster setting "indices.composite_index.star_tree.enabled" and index setting "index.search.star_tree_index.enabled" are "true"

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 135be39: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for f7b7caf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Rishab Nahata <[email protected]>
Copy link
Contributor

❌ Gradle check result for a97f1eb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Rishab Nahata <[email protected]>
Copy link
Contributor

❌ Gradle check result for 82001bc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Rishab Nahata <[email protected]>
Copy link
Contributor

❌ Gradle check result for 8bcc71f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Rishab Nahata <[email protected]>
Copy link
Contributor

❌ Gradle check result for 5eb7ac3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@imRishN imRishN requested a review from a team as a code owner April 30, 2025 11:18
Copy link
Contributor

❌ Gradle check result for 6c620ac: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants