-
Notifications
You must be signed in to change notification settings - Fork 2k
Modify numeric FieldMappers to enable SkipList #18066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Modify numeric FieldMappers to enable SkipList #18066
Conversation
4b29d6b
to
263e99a
Compare
❌ Gradle check result for 263e99a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: kkewwei <[email protected]> Signed-off-by: kkewwei <[email protected]>
263e99a
to
1a6b8f0
Compare
❌ Gradle check result for 1a6b8f0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: kkewwei <[email protected]>
❌ Gradle check result for 6622724: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
I'm inline with overall changes, one small query though: Do we want to add an benchmark for it? Something like this: https://github.com/opensearch-project/OpenSearch/blob/main/benchmarks/src/main/java/org/opensearch/benchmark/index/mapper/CustomBinaryDocValuesFieldBenchmark.java |
Description
[Describe what this change achieves]
Related Issues
Resolves #17965
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.