-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Increased the scope of File Interceptor to intercept methods from FileSystemProvider.class #17989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Gradle check result for e5c1ac7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for e5c1ac7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
libs/agent-sm/agent/src/main/java/org/opensearch/javaagent/FileInterceptor.java
Show resolved
Hide resolved
❌ Gradle check result for 4825849: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 8aa9cdc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 355d48b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 8771d25: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 7696898: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@reta FYI This is another instance where the agent is divergent from JSM with stack walking. The agent is not currently blocking After adding a check for
As you can see from the stack trace, its coming from instantiating the MonitoringService on the Node Bootstrap flow, which ends up calling OsProbe.getFreeSwapSpaceSize which is coming from the OperatingSystemMxBean In the stack trace I can see AccessController.doPrivileged with all JDK classes above the frame. With JSM authz is skipped here since its all JDK classes, but with the agent its going further up the stack. In this case, will we need to grants in ref Jenkins run with failures after intercepting |
❌ Gradle check result for 07fee01: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/resources/org/opensearch/bootstrap/test-framework.policy
Outdated
Show resolved
Hide resolved
❌ Gradle check result for da2a39b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
libs/agent-sm/agent/src/main/java/org/opensearch/javaagent/FileInterceptor.java
Outdated
Show resolved
Hide resolved
@cwperks you are very right, we have quite large API surface to cover, the incremental approach (like this one) would help us to close the gaps for sure, thank you
Yes, we may need to update policies, thank you. |
server/src/main/resources/org/opensearch/bootstrap/test-framework.policy
Outdated
Show resolved
Hide resolved
❌ Gradle check result for b89a18c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 4da2f19: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 4b869b0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for e27ef3c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 943d3c7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for bcd6044: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for a8c3dab: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 58fb0d7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…SystemProvider.class Signed-off-by: Pranav Reddy <[email protected]>
… being thrown Signed-off-by: Pranav Reddy <[email protected]>
Signed-off-by: Pranav Reddy <[email protected]>
…File Interceptor Signed-off-by: Pranav Reddy <[email protected]>
Signed-off-by: Pranav Reddy <[email protected]>
Signed-off-by: Pranav Reddy <[email protected]>
Signed-off-by: Pranav Reddy <[email protected]>
Description
Increased the scope o File Interceptor to intercept methods from FileSystemProvider.class and modified the i conditions to catch args baded on theit class types
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.