-
Notifications
You must be signed in to change notification settings - Fork 2k
[Pull-based Ingestion] Support versioning in pull-based ingestion #17918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3b1cee7
to
24a37c7
Compare
❕ Gradle check result for 24a37c7: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17918 +/- ##
============================================
- Coverage 72.52% 72.48% -0.05%
+ Complexity 67031 67002 -29
============================================
Files 5470 5470
Lines 309707 309780 +73
Branches 45052 45063 +11
============================================
- Hits 224617 224536 -81
- Misses 66774 66869 +95
- Partials 18316 18375 +59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good
server/src/main/java/org/opensearch/indices/pollingingest/MessageProcessorRunnable.java
Show resolved
Hide resolved
24a37c7
to
6426616
Compare
Signed-off-by: Varun Bharadwaj <[email protected]>
6426616
to
6f9aa2a
Compare
❌ Gradle check result for 6f9aa2a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 6f9aa2a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 6f9aa2a: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Description
This PR adds external versioning support in pull-based ingestion for users to handle out-of-order updates when streaming sources do not guarantee order. Pull-based ingestion will only support external versioning. Users must maintain versions externally and set it in the
_version
field in the message.index.gc_deletes
duration has passed from the deletion._version
is not provided in the message.The user is responsible to always send a version in every message when external versioning is used. If a version is not provided, the document is indexed irrespective of the document version found in the index.
Related Issues
Resolves #17913
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.