-
Notifications
You must be signed in to change notification settings - Fork 2k
[GRPC] Add terms query support in Search GRPC endpoint #17888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Gradle check result for a3f16c3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
a6d53e5
to
8584024
Compare
Signed-off-by: Karen Xu <[email protected]>
❕ Gradle check result for fb76ef6: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17888 +/- ##
============================================
+ Coverage 72.44% 72.52% +0.08%
- Complexity 66801 66871 +70
============================================
Files 5455 5457 +2
Lines 309183 309243 +60
Branches 44987 45004 +17
============================================
+ Hits 223981 224279 +298
+ Misses 66873 66614 -259
- Partials 18329 18350 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Karen Xu <[email protected]>
Signed-off-by: Karen Xu <[email protected]>
❌ Gradle check result for e89a57a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for e89a57a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for e89a57a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for e89a57a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Karen X <[email protected]>
❌ Gradle check result for 35f4b3b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 35f4b3b: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
…oject#17888) Signed-off-by: Karen Xu <[email protected]> Signed-off-by: Karen X <[email protected]> Signed-off-by: Sriram Ganesh <[email protected]>
This PR is stacked on top of #17895
Description
Implement Terms Query within GRPC Search API
Test Plan
a) TermsLookupField
POJOs both the same:
b) StringArray
SearchRequest POJOs are both the same:
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
#16783
#16784
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.