-
Notifications
You must be signed in to change notification settings - Fork 2k
Fix object field exists query #17843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: panguixin <[email protected]>
❌ Gradle check result for 5c90309: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@msfroh you may be interested in this, would you mind taking a look at this if you get a chance? |
❌ Gradle check result for 5c90309: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/index/query/ExistsQueryBuilder.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for f689409: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for f689409: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for f689409: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for f689409: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: panguixin <[email protected]>
Signed-off-by: panguixin <[email protected]>
f689409
to
17a49da
Compare
❌ Gradle check result for 17a49da: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 17a49da: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 5fb0074: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17843 +/- ##
============================================
- Coverage 72.58% 72.49% -0.09%
+ Complexity 67219 67199 -20
============================================
Files 5476 5476
Lines 310445 310444 -1
Branches 45121 45120 -1
============================================
- Hits 225324 225056 -268
- Misses 66780 67047 +267
Partials 18341 18341 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Marc Handalian <[email protected]>
Description
To fix #17808, there are three methods:
This PR chooses method 1 because it's simple and can cover all fields.
Related Issues
Resolves #17808
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.