Skip to content

Fix object field exists query #17843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 1, 2025
Merged

Conversation

bugmakerrrrrr
Copy link
Contributor

Description

To fix #17808, there are three methods:

  1. Ignore subfields that throw exceptions, i.e., do not support the exists query;
  2. Make all fields that do not support the exists query return MatchNoDocsQuery and do not throw exceptions;
  3. Provide a flag to indicate that a field is derived from another field, and ignore subfields of this type when creating an object field exists query

This PR chooses method 1 because it's simple and can cover all fields.

Related Issues

Resolves #17808

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Apr 8, 2025

❌ Gradle check result for 5c90309: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@bugmakerrrrrr
Copy link
Contributor Author

@msfroh you may be interested in this, would you mind taking a look at this if you get a chance?

Copy link
Contributor

github-actions bot commented Apr 9, 2025

❌ Gradle check result for 5c90309: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions github-actions bot added the v3.0.0 Issues and PRs related to version 3.0.0 label Apr 21, 2025
Copy link
Contributor

❌ Gradle check result for f689409: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for f689409: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for f689409: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for f689409: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 17a49da: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 17a49da: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 5fb0074: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 5fb0074: SUCCESS

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.49%. Comparing base (00abaac) to head (339820f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17843      +/-   ##
============================================
- Coverage     72.58%   72.49%   -0.09%     
+ Complexity    67219    67199      -20     
============================================
  Files          5476     5476              
  Lines        310445   310444       -1     
  Branches      45121    45120       -1     
============================================
- Hits         225324   225056     -268     
- Misses        66780    67047     +267     
  Partials      18341    18341              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mch2 mch2 requested a review from a team as a code owner May 1, 2025 17:56
Copy link
Contributor

github-actions bot commented May 1, 2025

✅ Gradle check result for 339820f: SUCCESS

@mch2 mch2 merged commit 987f4fa into opensearch-project:main May 1, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Search Search query, autocomplete ...etc v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Object Field exists query returns wrong result
3 participants