Remove dependency on :test:framework in :libs:opensearch-agent-sm:agent-policy #17821
Conversation
…nt-policy Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
anasalkouz,
andrross,
ashking94,
bugmakerrrrrr,
Bukhtawar,
CEHENKLE,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
Signed-off-by: Craig Perkins <[email protected]>
|
I had to disable some tasks to make the precommit work for this module. |
|
❌ Gradle check result for 1f532cd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 1f532cd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 1f532cd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for 1f532cd: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17821 +/- ##
============================================
- Coverage 72.55% 72.35% -0.20%
+ Complexity 66502 66468 -34
============================================
Files 5399 5408 +9
Lines 307755 308080 +325
Branches 44656 44720 +64
============================================
- Hits 223295 222920 -375
- Misses 66266 66958 +692
- Partials 18194 18202 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nt-policy (opensearch-project#17821) * Remove dependency on :test:framework in :libs:opensearch-agent-sm:agent-policy Signed-off-by: Craig Perkins <[email protected]> * Use JUnit Signed-off-by: Craig Perkins <[email protected]> * Disable more tasks Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
Description
This PR replaces the :test:framework dependency with JUnit directly in order to avoid circular dependencies on the
:libs:agent-sm:agent-policymoduleRelated Issues
Resolves https://github.com/opensearch-project/OpenSearch/pull/17753/files#r2031916820
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.