Cardinality Aggregation dynamic pruning null pointer exception catch

[ajleong623]

Description

There was a possibility of a null pointer exception error when the BooleanScorer passes in a null document. The document is assumed to not be null, and while that might be true for the DefaultBulkScorer, it is not checked in the BooleanScorer.

Related Issues

Resolves #17739

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❕ Gradle check result for 6a94385: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.39%. Comparing base (8312e42) to head (6a94385).
Report is 71 commits behind head on main.

Files with missing lines	Patch %	Lines
...ch/aggregations/metrics/CardinalityAggregator.java	0.00%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #17775      +/-   ##
============================================
- Coverage     72.51%   72.39%   -0.13%     
+ Complexity    66142    66062      -80     
============================================
  Files          5356     5356              
  Lines        306421   306425       +4     
  Branches      44393    44395       +2     
============================================
- Hits         222192   221824     -368     
- Misses        66024    66487     +463     
+ Partials      18205    18114      -91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bowenlan-amzn]

@jainankitk, @andrross could we merge this in for 3.0? We couldn't reproduce the NPE with real data, so currently we cannot easily cover the added null check.

[jainankitk]

While having bug fix without accompanying unit test is not ideal, I don't see any harm in having these checks to avoid any potential NPEs