[segment replication] Add cluster setting for retry timeout of publish checkpoint tx action #17749
Conversation
guojialiang92
requested review from
anasalkouz,
andrross,
ashking94,
bugmakerrrrrr,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
github-actions
bot
added
bug
|
❌ Gradle check result for 1edc0ca: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…eckpointAction use the never give up strategy. Signed-off-by: guojialiang <[email protected]>
guojialiang92
force-pushed
the
dev/PublishCheckpointAction_use_never_give_up_retry_strategy
branch
from
1edc0ca to
e49aa81
Compare
…Action_use_never_give_up_retry_strategy # Conflicts: # CHANGELOG.md
...er/src/internalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationIT.java
Outdated
Show resolved
Hide resolved
...er/src/internalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationIT.java
Show resolved
Hide resolved
...er/src/internalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationIT.java
Show resolved
Hide resolved
|
❕ Gradle check result for d333d0a: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
❌ Gradle check result for 2726e01: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
guojialiang92
force-pushed
the
dev/PublishCheckpointAction_use_never_give_up_retry_strategy
branch
from
2726e01 to
b744f4b
Compare
|
❌ Gradle check result for b744f4b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: guojialiang <[email protected]>
guojialiang92
force-pushed
the
dev/PublishCheckpointAction_use_never_give_up_retry_strategy
branch
from
b744f4b to
68a5e9d
Compare
|
❌ Gradle check result for 68a5e9d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…Action_use_never_give_up_retry_strategy # Conflicts: # CHANGELOG.md
|
❌ Gradle check result for 3eb976e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Restarted the pr build. |
|
❌ Gradle check result for 3eb976e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…Action_use_never_give_up_retry_strategy
|
❌ Gradle check result for a3a23a7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: guojialiang <[email protected]>
Description
Added a test. In the current situation, if the primary shard publish checkpoint fails, it will cause the replica shard and the primary shard to fail to synchronize.
TransportReplicationActionsupport specifying retryTimeout.PublishCheckpointActionuse the never give up retry strategy.Related Issues
Resolves 17595
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.