Skip to content

Introduce a new search node role to hold search only shards #17620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 18, 2025

Conversation

vinaykpud
Copy link
Contributor

Description

Introducing a new node role "search". This will be used for node to hold search replica

Related Issues

Related #17422

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
Copy link
Contributor

❌ Gradle check result for 75838a5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
Copy link
Contributor

❌ Gradle check result for 4717b9b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
@vinaykpud vinaykpud force-pushed the rw/add-search-role branch from 199f5ac to 972d73a Compare March 18, 2025 19:06
Copy link
Contributor

❌ Gradle check result for 972d73a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
Copy link
Contributor

❌ Gradle check result for add23cf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 51fe66b: SUCCESS

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.38%. Comparing base (1166998) to head (51fe66b).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17620      +/-   ##
============================================
- Coverage     72.48%   72.38%   -0.11%     
+ Complexity    65771    65688      -83     
============================================
  Files          5311     5311              
  Lines        304973   305011      +38     
  Branches      44229    44232       +3     
============================================
- Hits         221045   220767     -278     
- Misses        65830    66111     +281     
- Partials      18098    18133      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vinaykpud vinaykpud changed the title Introduce a new search node role Introduce a new search node role to hold search only shards Mar 18, 2025
@mch2 mch2 merged commit 14d740f into opensearch-project:main Mar 18, 2025
35 of 36 checks passed
vinaykpud added a commit to vinaykpud/OpenSearch that referenced this pull request Mar 18, 2025
…ch-project#17620)

* Introduce a new search node role

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* Add changelog

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* fixed PR comments

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* rename search to warm in FsProbe test

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* fixed ClusterStatsIT tests

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

* added ClusterStatsIT test for search node role

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>

---------

Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants