-
Notifications
You must be signed in to change notification settings - Fork 2k
Allow plugins to access/override some functions of ParametrizedFieldMapper; Modify the the constructor of the MappedFieldType to support FilterFieldType. #17575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
server/src/main/java/org/opensearch/index/mapper/TermBasedFieldType.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for 1cc9d6b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for e8c8411: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17575 +/- ##
============================================
- Coverage 72.44% 72.37% -0.08%
- Complexity 66483 66676 +193
============================================
Files 5409 5449 +40
Lines 308282 309080 +798
Branches 44759 44982 +223
============================================
+ Hits 223344 223699 +355
- Misses 66608 66973 +365
- Partials 18330 18408 +78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…apper; Modify the the constructor of the MappedFieldType to support FilterFieldType. Signed-off-by: Bo Zhang <[email protected]>
❌ Gradle check result for ed5264d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these changes make sense. Obviously, making stuff public
/ non-final
is not ideal, but the scope seems limited enough.
❌ Gradle check result for ed5264d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for ed5264d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for ed5264d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for ed5264d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…apper; Modify the the constructor of the MappedFieldType to support FilterFieldType. (opensearch-project#17575) Signed-off-by: Bo Zhang <[email protected]> Signed-off-by: Sriram Ganesh <[email protected]>
Description
Allow plugins to access/override some functions of ParametrizedFieldMapper;
Modify the the constructor of the MappedFieldType to support FilterFieldType.
Related Issues
This is needed to support this PR for this feature.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.