Skip to content

Allow plugins to access/override some functions of ParametrizedFieldMapper; Modify the the constructor of the MappedFieldType to support FilterFieldType. #17575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025

Conversation

bzhangam
Copy link
Contributor

@bzhangam bzhangam commented Mar 11, 2025

Description

Allow plugins to access/override some functions of ParametrizedFieldMapper;
Modify the the constructor of the MappedFieldType to support FilterFieldType.

Related Issues

This is needed to support this PR for this feature.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 1cc9d6b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for e8c8411: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.37%. Comparing base (7b6108b) to head (3df49a6).
Report is 20 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17575      +/-   ##
============================================
- Coverage     72.44%   72.37%   -0.08%     
- Complexity    66483    66676     +193     
============================================
  Files          5409     5449      +40     
  Lines        308282   309080     +798     
  Branches      44759    44982     +223     
============================================
+ Hits         223344   223699     +355     
- Misses        66608    66973     +365     
- Partials      18330    18408      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…apper; Modify the the constructor of the MappedFieldType to support FilterFieldType.

Signed-off-by: Bo Zhang <[email protected]>
@bzhangam bzhangam reopened this Apr 3, 2025
@bzhangam bzhangam changed the title Allow plugins outside core package to access and override some function of FieldMapper Allow plugins to access/override some functions of ParametrizedFieldMapper; Modify the the constructor of the MappedFieldType to support FilterFieldType. Apr 3, 2025
Copy link
Contributor

github-actions bot commented Apr 3, 2025

❌ Gradle check result for ed5264d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

@msfroh msfroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these changes make sense. Obviously, making stuff public / non-final is not ideal, but the scope seems limited enough.

Copy link
Contributor

github-actions bot commented Apr 4, 2025

❌ Gradle check result for ed5264d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 4, 2025

❌ Gradle check result for ed5264d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 4, 2025

❌ Gradle check result for ed5264d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 8, 2025

❌ Gradle check result for ed5264d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 9, 2025

✅ Gradle check result for 3df49a6: SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants