-
Notifications
You must be signed in to change notification settings - Fork 2k
Fix compilation issue for #17535 backport PR #17546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation issue for #17535 backport PR #17546
Conversation
Once this PR is merged, will backport https://github.com/opensearch-project/OpenSearch/pull/ and this PR manually into 2.x branch. |
Signed-off-by: Ashish Singh <[email protected]>
ab882ea
to
ba85652
Compare
❕ Gradle check result for ba85652: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17546 +/- ##
============================================
+ Coverage 71.54% 71.57% +0.03%
+ Complexity 64883 64850 -33
============================================
Files 5311 5311
Lines 304903 304941 +38
Branches 44215 44228 +13
============================================
+ Hits 218133 218275 +142
+ Misses 68896 68738 -158
- Partials 17874 17928 +54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…opensearch-project#17546) Signed-off-by: Ashish Singh <[email protected]>
…opensearch-project#17546) Signed-off-by: Ashish Singh <[email protected]>
* Fix flaky tests in RemoteStoreStatsIT (#17535) Signed-off-by: Ashish Singh <[email protected]> * Fix compilation issue for PR #17535 during backport (#17546) Signed-off-by: Ashish Singh <[email protected]> --------- Signed-off-by: Ashish Singh <[email protected]>
…opensearch-project#17546) Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
Description
During the build of backport PR #17543 (backport of #17535), the compilation is failing due to usage of methods introduced in jdk 16 & 21. In this PR, we have moved back to supported methods already being used.
Check List
[ ] Functionality includes testing.[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.