Skip to content

Fix compilation issue for #17535 backport PR #17546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

ashking94
Copy link
Member

Description

During the build of backport PR #17543 (backport of #17535), the compilation is failing due to usage of methods introduced in jdk 16 & 21. In this PR, we have moved back to supported methods already being used.

Check List

  • [ ] Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ashking94
Copy link
Member Author

Once this PR is merged, will backport https://github.com/opensearch-project/OpenSearch/pull/ and this PR manually into 2.x branch.

@ashking94 ashking94 changed the title Fix compilation issue for PR #17535 during backport Fix compilation issue for #17535 backport PR Mar 7, 2025
@ashking94 ashking94 force-pushed the fix-jdk-compilation branch from ab882ea to ba85652 Compare March 7, 2025 08:38
Copy link
Contributor

github-actions bot commented Mar 7, 2025

❕ Gradle check result for ba85652: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.classMethod
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode
      1 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.testResizeQueueDown

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.57%. Comparing base (7388205) to head (ba85652).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17546      +/-   ##
============================================
+ Coverage     71.54%   71.57%   +0.03%     
+ Complexity    64883    64850      -33     
============================================
  Files          5311     5311              
  Lines        304903   304941      +38     
  Branches      44215    44228      +13     
============================================
+ Hits         218133   218275     +142     
+ Misses        68896    68738     -158     
- Partials      17874    17928      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ashking94 ashking94 merged commit 6b45972 into opensearch-project:main Mar 7, 2025
31 checks passed
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Mar 7, 2025
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Mar 7, 2025
ashking94 added a commit that referenced this pull request Mar 7, 2025
* Fix flaky tests in RemoteStoreStatsIT (#17535)

Signed-off-by: Ashish Singh <[email protected]>

* Fix compilation issue for PR #17535 during backport (#17546)

Signed-off-by: Ashish Singh <[email protected]>

---------

Signed-off-by: Ashish Singh <[email protected]>
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants