-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Update validator for index.routing.allocation.total_primary_shards_per_node
for index update requests.
#17529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Divyansh Pandey <[email protected]>
❌ Gradle check result for 7ffccca: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17529 +/- ##
============================================
- Coverage 72.59% 72.45% -0.14%
+ Complexity 65798 65748 -50
============================================
Files 5311 5311
Lines 304888 304901 +13
Branches 44212 44214 +2
============================================
- Hits 221323 220926 -397
- Misses 65501 65871 +370
- Partials 18064 18104 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Covered in ITs |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-17529-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 73882054afcdb74244c07c5be1f54a629ffd0bc2
# Push it to GitHub
git push --set-upstream origin backport/backport-17529-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
Signed-off-by: Divyansh Pandey <[email protected]> Co-authored-by: Divyansh Pandey <[email protected]> Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
Description
When attempting to update the index.routing.allocation.total_primary_shards_per_node setting for an existing index in a remote store enabled cluster, an error is encountered stating that this setting can only be used with remote store enabled clusters, despite the cluster actually being remote store enabled.
Changes in this PR, updates the validator for update index setting. The change aims to resolve bug identified in #17295
Related Issues
Resolves #17473
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.