-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[Backport 2.x] Add verbose pipeline parameter to output each processor's execution #17097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Add verbose pipeline parameter to output each processor's execution #17097
Conversation
…etails (opensearch-project#16843) * Add verbose pipeline parameter to output each processor's execution details Signed-off-by: Junwei Dai <[email protected]> * add change log Signed-off-by: Junwei Dai <[email protected]> # Conflicts: # CHANGELOG.md * Refactor ProcessorExecutionDetail to improve field handling Signed-off-by: Junwei Dai <[email protected]> * Fix ITtest Fail Signed-off-by: Junwei Dai <[email protected]> * Add more unit test Signed-off-by: Junwei Dai <[email protected]> * resolve comments Signed-off-by: Junwei Dai <[email protected]> * 1.add todo to change version.current 2.use exist xcontentUtil to read 3.move processor excution key to ProcessorExecutionDetail Signed-off-by: Junwei Dai <[email protected]> * refactor code Signed-off-by: Junwei Dai <[email protected]> * refactor code based on the comment Signed-off-by: Junwei Dai <[email protected]> * refactor code based on the comment Signed-off-by: Junwei Dai <[email protected]> * 1.add javadoc 2.refactor error message Signed-off-by: Junwei Dai <[email protected]> * change error message Signed-off-by: Junwei Dai <[email protected]> * 1.Added wrappers for tracking execution details of search processors. 2.Removed redundant logic for cleaner and simpler implementation. Signed-off-by: Junwei Dai <[email protected]> * change version to 3.0.0 Signed-off-by: Junwei Dai <[email protected]> * fix unit test Signed-off-by: Junwei Dai <[email protected]> * fix unit test Signed-off-by: Junwei Dai <[email protected]> * addressed comments 1. removed unnecessary log Signed-off-by: Junwei Dai <[email protected]> * addressed comments Signed-off-by: Junwei Dai <[email protected]> * revise comment to opensearch.api Signed-off-by: Junwei Dai <[email protected]> * removed unused logger and comment Signed-off-by: Junwei Dai <[email protected]> * removed unnecessary try catch block. add more comment Signed-off-by: Junwei Dai <[email protected]> * addressed comments Signed-off-by: Junwei Dai <[email protected]> * remove wrong unit test Signed-off-by: Junwei Dai <[email protected]> --------- Signed-off-by: Junwei Dai <[email protected]> Co-authored-by: Junwei Dai <[email protected]> (cherry picked from commit e15f712) Signed-off-by: Junwei Dai <[email protected]>
@junweid62 -- can you add an override constructor to The "Detect Breaking Changes" action is complaining about the fact that you modified an existing constructor rather than adding an override:
You need to add a constructor that has the old signature that delegates to |
Signed-off-by: Junwei Dai <[email protected]>
Signed-off-by: Junwei Dai <[email protected]>
@msfroh @junweid62 we can add this constructor back on |
We don't need to. The 3.0 release is allowed to introduce API changes. |
Backport e15f712 from #16843.
Update version check to onOrAfter(Version.V_2_19_0)
Perform the BWC process:
1. Do this on main with onOrAfter(Version.V_3_0_0)). Get it merged.
2. You'll need a manual backport to 2.x, where you do onOrAfter(Version.V_2_19_0). Don't get it merged right away.
3. Before merging the backport to 2.x, open another PR on main to change it to onOrAfter(Version.V_2_19_0).
4. Merge the backport PR.
5. Merge the main version update PR.
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.