Fix: visit of inner query for FunctionScoreQueryBuilder #16776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kodieg
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
jainankitk and
linuxpi
as code owners
kodieg
force-pushed
the
main
branch
2 times, most recently
from
4c44ed6 to
43459a6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16776 +/- ##
============================================
+ Coverage 72.27% 72.33% +0.05%
- Complexity 65611 65674 +63
============================================
Files 5311 5311
Lines 304942 304946 +4
Branches 44225 44226 +1
============================================
+ Hits 220407 220584 +177
+ Misses 66448 66269 -179
- Partials 18087 18093 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
|
❌ Gradle check result for 48eae48: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Dec 10, 2024
added 3 commits
December 10, 2024 11:35
Signed-off-by: jdnvn <[email protected]>
Signed-off-by: jdnvn <[email protected]>
Signed-off-by: Konrad Gołuchowski <[email protected]>
|
This PR is stalled because it has been open for 30 days with no activity. |
Signed-off-by: gaobinlong <[email protected]>
gaobinlong
approved these changes
Mar 13, 2025
|
❕ Gradle check result for 25d411e: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
* add visitor logic to FunctionScoreQueryBuilder Signed-off-by: jdnvn <[email protected]> * update changelog Signed-off-by: jdnvn <[email protected]> * add assertion that inner query builder was visited Signed-off-by: Konrad Gołuchowski <[email protected]> --------- Signed-off-by: jdnvn <[email protected]> Signed-off-by: Konrad Gołuchowski <[email protected]> Signed-off-by: gaobinlong <[email protected]> Co-authored-by: jdnvn <[email protected]> Co-authored-by: gaobinlong <[email protected]> (cherry picked from commit 5a4c510) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Mar 13, 2025
) * add visitor logic to FunctionScoreQueryBuilder * update changelog * add assertion that inner query builder was visited --------- (cherry picked from commit 5a4c510) Signed-off-by: jdnvn <[email protected]> Signed-off-by: Konrad Gołuchowski <[email protected]> Signed-off-by: gaobinlong <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: jdnvn <[email protected]> Co-authored-by: gaobinlong <[email protected]>
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Mar 18, 2025
…roject#16776) * add visitor logic to FunctionScoreQueryBuilder Signed-off-by: jdnvn <[email protected]> * update changelog Signed-off-by: jdnvn <[email protected]> * add assertion that inner query builder was visited Signed-off-by: Konrad Gołuchowski <[email protected]> --------- Signed-off-by: jdnvn <[email protected]> Signed-off-by: Konrad Gołuchowski <[email protected]> Signed-off-by: gaobinlong <[email protected]> Co-authored-by: jdnvn <[email protected]> Co-authored-by: gaobinlong <[email protected]> Signed-off-by: Vinay Krishna Pudyodu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is version of #15404 cherrypicked on main.
Similar to #14739, but implements the visit method in FunctionScoreQueryBuilder to allow subqueries to be processed properly.
Related Issues
Resolves #15403
Similar to #15034
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.