Skip to content

Improve test run time for SnapshotResiliencyTests.testSnapshotPrimaryRelocations #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Conversation

abbashus
Copy link
Contributor

Signed-off-by: Abbas Hussain [email protected]

Description

Improves test run time for server/src/test/java/org/opensearch/snapshots/SnapshotResiliencyTests.testSnapshotPrimaryRelocations by reducing max datanode count and max shard count in testcase.

Issues Resolved

#579

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@abbashus abbashus self-assigned this Aug 30, 2021
@abbashus abbashus added the enhancement Enhancement or improvement to existing feature or request label Aug 30, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 8557098

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 8557098

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 8557098

@abbashus
Copy link
Contributor Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 8557098
Log 441

Reports 441

Copy link
Member

@saratvemulapalli saratvemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change @abbashus !
Just curious: how much amount of time is improved?

@abbashus
Copy link
Contributor Author

@saratvemulapalli Almost reduced by 2 minutes. Details here in issue.

@abbashus abbashus merged commit 9b4440d into opensearch-project:main Aug 30, 2021
@saratvemulapalli saratvemulapalli added the pending backport Identifies an issue or PR that still needs to be backported label Aug 30, 2021
@saratvemulapalli
Copy link
Member

@abbashus please backport this PR to 1.x.

abbashus added a commit that referenced this pull request Aug 30, 2021
@tlfeng tlfeng added v1.1.0 Issues, PRs, related to the 1.1.0 release v2.0.0 Version 2.0.0 Indexing & Search and removed pending backport Identifies an issue or PR that still needs to be backported labels Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Indexing & Search v1.1.0 Issues, PRs, related to the 1.1.0 release v2.0.0 Version 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants