Skip to content

Reduce iterations to improve test run time for SearchServiceTests.testSearchWhileIndexDeleted #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

abbashus
Copy link
Contributor

@abbashus abbashus commented Aug 30, 2021

Signed-off-by: Abbas Hussain [email protected]

Description

Improves test run time for server/src/test/java/org/opensearch/search/SearchServiceTests.testSearchWhileIndexDeleted by reducing max iterations.

See details here

Issues Resolved

#578

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed f6cdd5c

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success f6cdd5c

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success f6cdd5c

@abbashus
Copy link
Contributor Author

start gradle check

@abbashus abbashus self-assigned this Aug 30, 2021
@abbashus abbashus added the enhancement Enhancement or improvement to existing feature or request label Aug 30, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success f6cdd5c
Log 440

Reports 440

@saratvemulapalli saratvemulapalli added the backport PRs or issues specific to backporting features or enhancments label Aug 30, 2021
@saratvemulapalli
Copy link
Member

Thanks @abbashus the changes look good to me.
Please backport the change to 1.x

@abbashus abbashus merged commit 91d9922 into opensearch-project:main Aug 30, 2021
abbashus added a commit that referenced this pull request Aug 30, 2021
@tlfeng tlfeng added Indexing & Search v1.1.0 Issues, PRs, related to the 1.1.0 release v2.0.0 Version 2.0.0 and removed backport PRs or issues specific to backporting features or enhancments labels Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Indexing & Search v1.1.0 Issues, PRs, related to the 1.1.0 release v2.0.0 Version 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants