Fix failure in SearchCancellationIT.testMSearchChildReqCancellationWi… #1105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thHybridTimeout In some cases as one shared with issue opensearch-project#1099, the maxConcurrentSearchRequests was chosen as 0 which will compute the final value during execution of the request based on processor counts. When this computed value is less than number of search request in msearch request, it will execute all the requests in multiple iterations causing the failure since test will only wait for one such iteration. Hence setting the maxConcurrentSearchRequests explicitly to number of search requests being added in the test to ensure correct behavior Signed-off-by: Sorabh Hamirwasia <[email protected]>
|
✅ DCO Check Passed bb0af40 |
|
✅ Gradle Wrapper Validation success bb0af40 |
|
✅ Gradle Precommit success bb0af40 |
|
start gradle check |
nknize
added
>test-failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…thHybridTimeout
In some cases as one shared with issue #1099, the maxConcurrentSearchRequests was chosen as 0 which
will compute the final value during execution of the request based on processor counts. When this
computed value is less than number of search request in msearch request, it will execute all the
requests in multiple iterations causing the failure since test will only wait for one such
iteration. Hence setting the maxConcurrentSearchRequests explicitly to number of search requests
being added in the test to ensure correct behavior
Signed-off-by: Sorabh Hamirwasia [email protected]
Description
Port of #1103 to 1.1 branch
Issues Resolved
Test failure
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.