Avoid crashing on using the index.lifecycle.name in the API body #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: frotsch <[email protected]>
|
✅ Gradle Wrapper Validation success d2111f6 |
|
✅ DCO Check Passed d2111f6 |
|
✅ Gradle Precommit success d2111f6 |
dblock
reviewed
Aug 9, 2021
| @@ -1044,7 +1044,10 @@ public void validateIndexSettings(String indexName, final Settings settings, fin | |||
| for (final String key : settings.keySet()) { | |||
| final Setting<?> setting = indexScopedSettings.get(key); | |||
| if (setting == null) { | |||
| assert indexScopedSettings.isPrivateSetting(key) : "expected [" + key + "] to be private but it was not"; | |||
| //https://github.com/opensearch-project/OpenSearch/issues/1019 | |||
There was a problem hiding this comment.
I see a lot of "// see: [github link]" in the code, maybe we can just adopt that "convention"
The fact that there's no space after // is really hurting my OCD ;)
Signed-off-by: frotsch <[email protected]>
|
✅ DCO Check Passed e3c4f54 |
|
✅ Gradle Wrapper Validation success e3c4f54 |
|
✅ Gradle Precommit success e3c4f54 |
|
start gradle check |
dblock
approved these changes
Aug 10, 2021
dblock
added
the
backport
|
Merged, could you please backport PR this one into 1.1 @frotsch? |
|
How exactly can I backport the PR? @dblock |
|
Make a new branch off |
frotsch
added a commit
to frotsch/OpenSearch
that referenced
this pull request
Aug 10, 2021
…nsearch-project#1060) * Avoid crashing on using the index.lifecycle.name in the API body Signed-off-by: frotsch <[email protected]>
2 tasks
dblock
pushed a commit
that referenced
this pull request
Aug 10, 2021
…) (#1070) * Avoid crashing on using the index.lifecycle.name in the API body Signed-off-by: frotsch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: frotsch [email protected]
Description
Fix OpenSearch process crashing on using the index.lifecycle.name in the API body when asserts are enabled
Issues Resolved
#1019
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.