Retry on file/folder deletion with Windows longpath support

.lycheeignore

@@ -93,3 +93,4 @@ site.com
 http://sites.google.com/site/murmurhash/
 helpmenow.com
 http://dev.w3.org/
+https://qntm.org/cmd

release-notes/opensearch-dashboards.release-notes-3.0.0-alpha1.md

@@ -60,6 +60,7 @@
  - Clear discover summary if t2ppl failed ([#9552](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9552))
  - Query-assist removed the placeholder of last ask question ([#9552](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9552))
  - Use markdown in discover summary ([#9553](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9553))
+ - Retry on file/folder deletion with Windows longpath support ([#9561](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9561))
 
 ### 🚞 Infrastructure
 
@@ -108,4 +109,4 @@
  - [TESTID-234] Add tests for query editor display ([#9398](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9398))
  - Fix flakieness in cypress tests ([#9433](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9433))
  - Use before/after to speed up test ([#9439](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9439))
- - Clear session storage in S3 integ test and update workflow ([#9490](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9490))
+ - Clear session storage in S3 integ test and update workflow ([#9490](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9490))

src/dev/build/lib/fs.ts

@@ -44,6 +44,7 @@
 import deleteEmpty from 'delete-empty';
 import tar, { ExtractOptions } from 'tar';
 import { ToolingLog } from '@osd/dev-utils';
+import { standardize } from '@osd/cross-platform';
 
 const pipelineAsync = promisify(pipeline);
 const mkdirAsync = promisify(fs.mkdir);
@@ -120,7 +121,24 @@
     dryRun: true,
   });
 
-  await Promise.all(filesToDelete.map((folder) => rm(folder, { force: true, recursive: true })));
+  await Promise.all(
+    filesToDelete.map(async (folder) => {
+      if (process.platform === 'win32') {
+        folder = standardize(folder, false, false, true); // extended long path
+      }
+
+      for (let i = 0; i < 3; i++) {
+        try {
+          await rm(folder, { force: true, recursive: true });
+          return;
+        } catch (err) {
+          if (i === 2) throw err;
+          log.debug(`Retry ${i + 1}/3 on ${folder}, waiting for 1000ms`);
+          await new Promise((resolveSleep) => setTimeout(resolveSleep, 1000));
+        }
+      }
+    })
+  );
 
   if (log) {
     log.debug('Deleted %d files/directories', filesToDelete.length);
@@ -155,7 +173,24 @@
       })
     : [];
 
-  await Promise.all(foldersToDelete.map((folder) => rm(folder, { force: true, recursive: true })));
+  await Promise.all(
+    foldersToDelete.map(async (folder) => {
+      if (process.platform === 'win32') {
+        folder = standardize(folder, false, false, true); // extended long path
+      }
+
+      for (let i = 0; i < 3; i++) {
+        try {
+          await rm(folder, { force: true, recursive: true });
+          return;
+        } catch (err) {
+          if (i === 2) throw err;
+          log.debug(`Retry ${i + 1}/3 on ${folder}, waiting for 1000ms`);
+          await new Promise((resolveSleep) => setTimeout(resolveSleep, 1000));
+        }
+      }
+    })
+  );
 
   log.debug('Deleted %d empty folders', foldersToDelete.length);
   log.verbose('Deleted:', longInspect(foldersToDelete));