-
Notifications
You must be signed in to change notification settings - Fork 1k
[Backport 2.x]Add extension point in saved object management to register namespaces and show filter (#2656) #2690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AMoo-Miki
merged 1 commit into
opensearch-project:2.x
from
zhongnansu:backport/backport-2656-to-2.x
Oct 31, 2022
Merged
[Backport 2.x]Add extension point in saved object management to register namespaces and show filter (#2656) #2690
AMoo-Miki
merged 1 commit into
opensearch-project:2.x
from
zhongnansu:backport/backport-2656-to-2.x
Oct 31, 2022
+335
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
06887f9
to
adda363
Compare
@zhongnansu / @opensearch-project/opensearch-dashboards-core The test failures do not look related to the changes. Would you please re-run the failed jobs?
BWC test failures:
|
… and show filter (opensearch-project#2656) * Create filter registry for saved object management to make filters extensible Signed-off-by: Craig Perkins <[email protected]> * WIP on making fetchCounts generic Signed-off-by: Craig Perkins <[email protected]> * First step at making scroll_counts generic Signed-off-by: Craig Perkins <[email protected]> * Work on getting other filter counts with same object count endpoint Signed-off-by: Craig Perkins <[email protected]> * Get tenant count options to display Signed-off-by: Craig Perkins <[email protected]> * Extend find to work with namespaces for saved objects Signed-off-by: Craig Perkins <[email protected]> * Add missing filterFields Signed-off-by: Craig Perkins <[email protected]> * Update jest tests Signed-off-by: Craig Perkins <[email protected]> * Update saved_objects_table snapshot Signed-off-by: Craig Perkins <[email protected]> * Append index to id to make unique Signed-off-by: Craig Perkins <[email protected]> * Add semi-colon Signed-off-by: Craig Perkins <[email protected]> * Fix saved objects table tests with new id scheme Signed-off-by: Craig Perkins <[email protected]> * Only append idx on config type to ensure Advanced Settings have a unique id across tenants Signed-off-by: Craig Perkins <[email protected]> * Remove itemsClone in favor of showing only Advanced Settings of current tenant Signed-off-by: Craig Perkins <[email protected]> * Revert snapshots in table.test.tsx Signed-off-by: Craig Perkins <[email protected]> * Add additional parse_query test Signed-off-by: Craig Perkins <[email protected]> * Add comma Signed-off-by: Craig Perkins <[email protected]> * Create namespaceRegistry to decouple security dashboards plugin and osd core Signed-off-by: Craig Perkins <[email protected]> * Add ability to register an alias Signed-off-by: Craig Perkins <[email protected]> * Update parse query and add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Remove commented out code Signed-off-by: Craig Perkins <[email protected]> * Address code review comments Signed-off-by: Craig Perkins <[email protected]> * Override i18n if alias is regitered Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 8ac127a) Signed-off-by: Su <[email protected]>
adda363
to
ce3e235
Compare
I don't think the DCO failure is valid. |
joshuarrrr
approved these changes
Oct 31, 2022
zengyan-amazon
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 8ac127a from #2656
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr