Skip to content

[Explore] Move column inferring to initialization stage #10054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Qxisylolo
Copy link
Contributor

Description

this pr moves column inferring to initialization stage

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: move column inferring to initialization stage

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Qxisylolo <[email protected]>
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (query_explore@5ece016). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             query_explore   #10054   +/-   ##
================================================
  Coverage                 ?   60.09%           
================================================
  Files                    ?     4077           
  Lines                    ?   103962           
  Branches                 ?    16548           
================================================
  Hits                     ?    62473           
  Misses                   ?    37348           
  Partials                 ?     4141           
Flag Coverage Δ
Linux_1 27.89% <ø> (?)
Linux_2 41.63% <ø> (?)
Windows_1 27.90% <ø> (?)
Windows_2 41.61% <ø> (?)
Windows_3 39.29% <ø> (?)
Windows_4 30.01% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Qxisylolo Qxisylolo changed the title Move column inferring to initialization stage [Explore] Move column inferring to initialization stage Jul 2, 2025
@raintygao
Copy link
Collaborator

@Qxisylolo There are some conflicts, could you resolve them first?

@Qxisylolo
Copy link
Contributor Author

Qxisylolo commented Jul 4, 2025

#10054 (comment)
I will close this pr temporarily as there will be changes in vis control.

@Qxisylolo Qxisylolo closed this Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants