-
Notifications
You must be signed in to change notification settings - Fork 1k
[BUG][NewHomePage] Avoid Requiring Index Write Permission for the New Homepage Loading #6320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks @Flyingliuhub @ashwin-pc @bbarani @wbeckler do you think we should conduct a patch release to include fix for this? cc: @kgcreative @elfisher |
Based on feedback from @ashwin-pc, this bug is in an opt-in feature and the new dashboard is not enabled by default so the risk is low. Please let me know if you think otherwise. |
not sure how we define the opt-in feature, compare the experimental feature , GA feature.
|
@Flyingliuhub I am not able reproduce this. Here are my steps:
Here is the video, and start at 40s |
@ananzh You are visit default home, not newhome page, you need to visit the new home page for repro the issue |
@Flyingliuhub will revisit this in 2.15 |
Issue is in src/plugins/home/public/services/section_type/section_type.ts . Fix is to update
to
|
@ananzh 2.15 is release soon. do you have a fix for this issue? we still saw this error in the future.playground with 2.15 build |
…th no write permission Issue Resolve: opensearch-project#6320 Signed-off-by: Anan Zhuang <[email protected]>
…e permission (#7054) * [BUG][NewHomePage] Temp Solution to avoid crash for anonymous user with no write permission Issue Resolve: #6320 --------- Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 25009ba) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…e permission (#7054) * [BUG][NewHomePage] Temp Solution to avoid crash for anonymous user with no write permission Issue Resolve: #6320 --------- Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 25009ba) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…e permission (#7054) (#7063) * [BUG][NewHomePage] Temp Solution to avoid crash for anonymous user with no write permission Issue Resolve: #6320 --------- (cherry picked from commit 25009ba) Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…e permission (#7054) (#7064) * [BUG][NewHomePage] Temp Solution to avoid crash for anonymous user with no write permission Issue Resolve: #6320 --------- (cherry picked from commit 25009ba) Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…e permission (opensearch-project#7054) * [BUG][NewHomePage] Temp Solution to avoid crash for anonymous user with no write permission Issue Resolve: opensearch-project#6320 --------- Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Introduced a new framework for dynamic content rendering #7201, the issue no longer existing, closing this now. |
Describe the bug
The new homepage was introduced in the 2.13 release, which required index write permission when loading. However, this should be avoided as dashboard users may not have index write permission.
To Reproduce
Steps to reproduce the behavior:
Steps to reproduce the behavior in local cluster:
yarn opensearch snapshot --security
yarn start --no-base-path
Global tenant
readall
and add Global tenant read permissiontest
and map to the copiedreadall_copy
roletest
user which created in the step 5Expected behavior
The new home page loading should not required to index write permission
Impact
In case of admin enabled advance setting in the global tenant, all the readonly users under global tenant will impact when visit new home page.
OpenSearch Version
8.13.0
Dashboards Version
2.13.0
Plugins
All the official release plugins
Screenshots
newhomepageissue2.mov
Host/Environment (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: