fix: remove unused imports after deleting a method argument

[pdelagrave]

What's changed?

An import will now be removed if the argument deletion by the DeleteMethodArgument recipe leaves it unused.

What's your motivation?

So we can simplify recipes using DeleteMethodArgument, no need to explicitly call RemoveUnusedImports afterwards anymore.

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

@timtebeek

Have you considered any alternatives or workarounds?

Any additional context

• Came up when working on Improve httpclient 4->5 AuthScheme-related migration rewrite-apache#85

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

Tests look good so far. Thanks for getting this started.

[timtebeek]

Thanks for the fix here! I like the variety you've used in your tests to guarantee we can remove various different styles of imports. The changes here are additive and mostly defensive, for a recipe that's up to now sparingly used in

• Mockito migrations in rewrite-testing-frameworks
  • https://github.com/openrewrite/rewrite-testing-frameworks/blob/79e3b3f46345ea526131fc7fb5791bd94002aad3/src/main/resources/META-INF/rewrite/mockito.yml#L111-L140
• Jakarta 10 servlet migrations
  • https://github.com/openrewrite/rewrite-migrate-java/blob/a141c96ba43b41117c12c5c2a8b7facd0e07bb65/src/main/resources/META-INF/rewrite/jakarta-ee-10.yml#L335-L352

With that I see not reason to hold off on a merge, such that we can unblock and simplify the work done on

• openrewrite/rewrite-apache#85 (comment)

Not merging right now myself, as I think that's best done when everyone is back to work Monday.